Re: Fix crash with -fdump-ada-spec

2019-08-21 Thread Joseph Myers
On Wed, 21 Aug 2019, Eric Botcazou wrote: > > Rather than checking if the outermost declarator is > > cdk_function and using its parameters if so, it's necessary to check if > > the *innermost declarator that isn't cdk_id or cdk_attrs* is cdk_function > > and use its parameters if so, as that's wh

Re: Fix crash with -fdump-ada-spec

2019-08-21 Thread Eric Botcazou
> The problem is that the logic in c_parser_declaration_or_fndef for setting > DECL_ARGUMENTS (not previously meaningful in non-definition declarations > at all), as introduced by > > r253411 | dmalcolm | 2017-10-04 14:10:59 + (Wed, 04 Oct 2017) | 85 lines > > C: underline parameters in misma

Re: Fix crash with -fdump-ada-spec

2019-08-21 Thread Joseph Myers
On Wed, 21 Aug 2019, Eric Botcazou wrote: > This fixes a crash of the C compiler when -fdump-ada-spec is passed for: > > extern void (*signal (int __sig, void (*__handler)(int)))(int); > > It appears that the C parser is somewhat confused by this declaration and > builds a FUNCTION_DECL whose t

Fix crash with -fdump-ada-spec

2019-08-21 Thread Eric Botcazou
This fixes a crash of the C compiler when -fdump-ada-spec is passed for: extern void (*signal (int __sig, void (*__handler)(int)))(int); It appears that the C parser is somewhat confused by this declaration and builds a FUNCTION_DECL whose type has got 2 arguments (TYPE_ARG_TYPES list) but whic