Re: Fix bootstrap issue with gcc 4.1

2017-05-04 Thread Jan Hubicka
> On Thu, May 4, 2017 at 11:04 AM, Jan Hubicka wrote: > >> > > >> >Sure, I'm not questioning the patch, just wondering if we shouldn't > >> >improve > >> >store-merging further (we want to do it anyway for e.g. bitop adjacent > >> >operations etc.). > >> > >> We definitely want to do that. It sho

Re: Fix bootstrap issue with gcc 4.1

2017-05-04 Thread Richard Biener
On Thu, May 4, 2017 at 11:04 AM, Jan Hubicka wrote: >> > >> >Sure, I'm not questioning the patch, just wondering if we shouldn't >> >improve >> >store-merging further (we want to do it anyway for e.g. bitop adjacent >> >operations etc.). >> >> We definitely want to do that. It should also 'nicely

Re: Fix bootstrap issue with gcc 4.1

2017-05-04 Thread Jan Hubicka
> > > >Sure, I'm not questioning the patch, just wondering if we shouldn't > >improve > >store-merging further (we want to do it anyway for e.g. bitop adjacent > >operations etc.). > > We definitely want to do that. It should also 'nicely' merge with bswap for > gathering the load side of a piec

Re: Fix bootstrap issue with gcc 4.1

2017-05-03 Thread Richard Biener
On May 3, 2017 6:46:05 PM GMT+02:00, Jakub Jelinek wrote: >On Wed, May 03, 2017 at 06:44:46PM +0200, Richard Biener wrote: >> On May 3, 2017 6:22:14 PM GMT+02:00, Jakub Jelinek >wrote: >> >On Wed, May 03, 2017 at 06:18:08PM +0200, Jan Hubicka wrote: >> >> Hi, >> >> my change to sreals makes GCC t

Re: Fix bootstrap issue with gcc 4.1

2017-05-03 Thread Jakub Jelinek
On Wed, May 03, 2017 at 06:44:46PM +0200, Richard Biener wrote: > On May 3, 2017 6:22:14 PM GMT+02:00, Jakub Jelinek wrote: > >On Wed, May 03, 2017 at 06:18:08PM +0200, Jan Hubicka wrote: > >> Hi, > >> my change to sreals makes GCC to be miscompiled with GCC 4.1 and -O0. > > This is > >> related t

Re: Fix bootstrap issue with gcc 4.1

2017-05-03 Thread Jakub Jelinek
On Wed, May 03, 2017 at 06:39:18PM +0200, Jan Hubicka wrote: > > On Wed, May 03, 2017 at 06:18:08PM +0200, Jan Hubicka wrote: > > > Hi, > > > my change to sreals makes GCC to be miscompiled with GCC 4.1 and -O0. > > > This is > > > related to fact that using sreal implies a non-trivial constructo

Re: Fix bootstrap issue with gcc 4.1

2017-05-03 Thread Richard Biener
On May 3, 2017 6:22:14 PM GMT+02:00, Jakub Jelinek wrote: >On Wed, May 03, 2017 at 06:18:08PM +0200, Jan Hubicka wrote: >> Hi, >> my change to sreals makes GCC to be miscompiled with GCC 4.1 and -O0. > This is >> related to fact that using sreal implies a non-trivial constructor >and thus >> ggc_c

Re: Fix bootstrap issue with gcc 4.1

2017-05-03 Thread Jan Hubicka
> On Wed, May 03, 2017 at 06:18:08PM +0200, Jan Hubicka wrote: > > Hi, > > my change to sreals makes GCC to be miscompiled with GCC 4.1 and -O0. This > > is > > related to fact that using sreal implies a non-trivial constructor and thus > > ggc_cleared_alloc is no longer standard compliant. I ho

Re: Fix bootstrap issue with gcc 4.1

2017-05-03 Thread Jakub Jelinek
On Wed, May 03, 2017 at 06:18:08PM +0200, Jan Hubicka wrote: > Hi, > my change to sreals makes GCC to be miscompiled with GCC 4.1 and -O0. This is > related to fact that using sreal implies a non-trivial constructor and thus > ggc_cleared_alloc is no longer standard compliant. I however do not qu

Fix bootstrap issue with gcc 4.1

2017-05-03 Thread Jan Hubicka
Hi, my change to sreals makes GCC to be miscompiled with GCC 4.1 and -O0. This is related to fact that using sreal implies a non-trivial constructor and thus ggc_cleared_alloc is no longer standard compliant. I however do not quite understand why GCC 4.1 manages to misoptimize this code but I ha