Re: Fix alias.c wrt aliases and anchors

2016-01-13 Thread Richard Sandiford
> here is updated patch that assumes by default that RTL SYMBOL_REFs may overlap > in arbitrary way and only disambiguate refs with declarations (same way as > tree > oracle does) and the anchors. > > Bootstrapped/regtested ppc64-linux. > Does it look resonable? The logic looks ok to me FWIW. I

Re: Fix alias.c wrt aliases and anchors

2016-01-13 Thread Jan Hubicka
Hi, here is updated patch that assumes by default that RTL SYMBOL_REFs may overlap in arbitrary way and only disambiguate refs with declarations (same way as tree oracle does) and the anchors. Bootstrapped/regtested ppc64-linux. Does it look resonable? Honza * alias.c (compare_base_symbol

Re: Fix alias.c wrt aliases and anchors

2015-12-28 Thread Uros Bizjak
Hello! >> Yeah, I think handling anchors is a good thing. It just seems that >> logically the correctness fix is to replace: >> >> /* Label and normal symbol are never the same. */ >>if (x_decl != y_decl) >>return 0; >> return offset_overlap_p (c, xsize, ysize); >> >> with something lik

Re: Fix alias.c wrt aliases and anchors

2015-12-28 Thread Jan Hubicka
> > Well, to me "weaker" means "makes more conservative assumptions", > which in this context would be assuming a conflict in cases where > the old code didn't (i.e. returning -1 more often). I'm not sure > whether the first patch was strictly weaker in that sense, since > if the symbol_refs were

Re: Fix alias.c wrt aliases and anchors

2015-12-22 Thread Richard Sandiford
Jan Hubicka writes: >> > Hi, >> > the alias-2.c testcase fails on targets with anchors. The reason is that >> > the variable itself is anchored while the alias is not and they point to >> > the >> > same location. I folllowed the docs of SYMBOL_REF claiming that >> > SYMBOL_REF_DECL if the sym

Re: Fix alias.c wrt aliases and anchors

2015-12-18 Thread Jan Hubicka
> > Hi, > > the alias-2.c testcase fails on targets with anchors. The reason is that > > the variable itself is anchored while the alias is not and they point to the > > same location. I folllowed the docs of SYMBOL_REF claiming that > > SYMBOL_REF_DECL if the symbol is label and tought it is sa

Re: Fix alias.c wrt aliases and anchors

2015-12-18 Thread Richard Sandiford
> Hi, > the alias-2.c testcase fails on targets with anchors. The reason is that > the variable itself is anchored while the alias is not and they point to the > same location. I folllowed the docs of SYMBOL_REF claiming that > SYMBOL_REF_DECL if the symbol is label and tought it is safe to disa

Fix alias.c wrt aliases and anchors

2015-12-17 Thread Jan Hubicka
Hi, the alias-2.c testcase fails on targets with anchors. The reason is that the variable itself is anchored while the alias is not and they point to the same location. I folllowed the docs of SYMBOL_REF claiming that SYMBOL_REF_DECL if the symbol is label and tought it is safe to disambiguate t