Re: Fix PRE heuristic for partial insertions

2012-11-15 Thread Jakub Jelinek
On Thu, Nov 15, 2012 at 11:04:12PM +0100, Steven Bosscher wrote: > On Thu, Nov 15, 2012 at 4:45 PM, Jakub Jelinek wrote: > > On Thu, Nov 15, 2012 at 11:25:55AM +0100, Jan Hubicka wrote: > >> PR tree-optimization/54717 > >> * tree-ssa-pre.c (do_partial_partial_insertion): Consider also e

Re: Fix PRE heuristic for partial insertions

2012-11-15 Thread Steven Bosscher
On Thu, Nov 15, 2012 at 4:45 PM, Jakub Jelinek wrote: > On Thu, Nov 15, 2012 at 11:25:55AM +0100, Jan Hubicka wrote: >> PR tree-optimization/54717 >> * tree-ssa-pre.c (do_partial_partial_insertion): Consider also edges >> with ANTIC_IN. > > As Richard is still away, Steven, could

Re: Fix PRE heuristic for partial insertions

2012-11-15 Thread Jan Hubicka
> On Thu, Nov 15, 2012 at 11:25:55AM +0100, Jan Hubicka wrote: > > PR tree-optimization/54717 > > * tree-ssa-pre.c (do_partial_partial_insertion): Consider also edges > > with ANTIC_IN. > > As Richard is still away, Steven, could you please comment on this? > > > Index: tree-ssa-pre.c

Re: Fix PRE heuristic for partial insertions

2012-11-15 Thread Jakub Jelinek
On Thu, Nov 15, 2012 at 11:25:55AM +0100, Jan Hubicka wrote: > PR tree-optimization/54717 > * tree-ssa-pre.c (do_partial_partial_insertion): Consider also edges > with ANTIC_IN. As Richard is still away, Steven, could you please comment on this? > Index: tree-ssa-pre.c > ===

Re: Fix PRE heuristic for partial insertions

2012-11-15 Thread Jan Hubicka
> Hi, > as observed on PR54717 we give up on some partial insertions because of > Skipping partial partial redundancy for expression > {array_ref,mem_ref<0B>,xxtrt_46(D)}@.MEM_30(D) (0165) not > partially anticipated on any to be optimized for speed edges > > The logic here is wrong, the edges a

Fix PRE heuristic for partial insertions

2012-11-15 Thread Jan Hubicka
Hi, as observed on PR54717 we give up on some partial insertions because of Skipping partial partial redundancy for expression {array_ref,mem_ref<0B>,xxtrt_46(D)}@.MEM_30(D) (0165) not partially anticipated on any to be optimized for speed edges The logic here is wrong, the edges are tested by o