Re: Fix PR81360

2017-11-20 Thread Eric Botcazou
> It was a typo in the conditional (I cleaned it up just before comitting > because I noticed I can merge it with earlier conditional and accidentally > dropped !). It should be fixed now. OK, thanks, unfortunately the bug made it into the latest source snapshot. -- Eric Botcazou

Re: Fix PR81360

2017-11-20 Thread Jan Hubicka
> > I believe this caused hundreds of new FAILs on both x86_64 and i686-linux. > > Seems after this change we no longer inline always_inline functions into > > -O0 callers, which is wrong. > > That's worse than this, inlining is totally broken... It was a typo in the conditional (I cleaned it up

Re: Fix PR81360

2017-11-20 Thread Eric Botcazou
> I believe this caused hundreds of new FAILs on both x86_64 and i686-linux. > Seems after this change we no longer inline always_inline functions into > -O0 callers, which is wrong. That's worse than this, inlining is totally broken... -- Eric Botcazou

Re: Fix PR81360

2017-11-19 Thread Jakub Jelinek
On Sun, Nov 19, 2017 at 09:06:19PM +0100, Jan Hubicka wrote: > Hi, > this testcase triggers ICE because we try to inline into -O0 function. > Fixed thus. > > Bootstrapped/regtested x86_64-linux, comitted. > > Honza > > * gcc.c-torture/compile/pr81360.c: New testcase. > * ipa-inline.c

Fix PR81360

2017-11-19 Thread Jan Hubicka
Hi, this testcase triggers ICE because we try to inline into -O0 function. Fixed thus. Bootstrapped/regtested x86_64-linux, comitted. Honza * gcc.c-torture/compile/pr81360.c: New testcase. * ipa-inline.c (can_inline_edge_p): Also check that caller is optimized Index: testsuite/gc