Re: OMP_CLAUSES with clauses in operand 0 (was: Fix OpenMP's target update directive in templated code)

2015-04-29 Thread Jakub Jelinek
On Wed, Apr 29, 2015 at 11:28:55AM +0200, Thomas Schwinge wrote: > Yet, if that's a non-starter, I'll pursue this one: Yeah, it is a non-starter, it has unnecessary runtime overhead everywhere where it is used. Jakub

OMP_CLAUSES with clauses in operand 0 (was: Fix OpenMP's target update directive in templated code)

2015-04-29 Thread Thomas Schwinge
Hi Jakub! On Wed, 29 Apr 2015 10:53:32 +0200, Jakub Jelinek wrote: > On Tue, Apr 28, 2015 at 08:45:50PM +0200, Thomas Schwinge wrote: > > That said, what is the preferred approach to add support for > > OACC_ENTER_DATA, OACC_EXIT_DATA, OACC_UPDATE? I'm not sure hard-coding > > TREE_OPERAND (t, 0

Re: Fix OpenMP's target update directive in templated code

2015-04-29 Thread Thomas Schwinge
Hi Jakub! On Wed, 29 Apr 2015 10:53:32 +0200, Jakub Jelinek wrote: > On Tue, Apr 28, 2015 at 08:45:50PM +0200, Thomas Schwinge wrote: > > I guess nobody so far ;-) has been using OpenMP's target update directive > > in templated code -- OK to commit the following, and to which branches > > (4.9,

Re: Fix OpenMP's target update directive in templated code

2015-04-29 Thread Jakub Jelinek
On Tue, Apr 28, 2015 at 08:45:50PM +0200, Thomas Schwinge wrote: > I guess nobody so far ;-) has been using OpenMP's target update directive > in templated code -- OK to commit the following, and to which branches > (4.9, 5, trunk)? Seems I've missed testcases for target {,update,data} in template

Fix OpenMP's target update directive in templated code

2015-04-28 Thread Thomas Schwinge
_stmt (t); > - break; > - > case OACC_ENTER_DATA: > case OACC_EXIT_DATA: > case OACC_UPDATE: I guess nobody so far ;-) has been using OpenMP's target update directive in templated code -- OK to commit the following, and to which branches (4.9, 5, trunk)? commit 5e