Re: Fix ICEs on ODR violating programs and improve ODR mismatch diagnostic

2015-03-23 Thread Jan Hubicka
> On Mon, Mar 23, 2015 at 04:07:10PM +0100, Richard Biener wrote: > > On Mon, Mar 23, 2015 at 3:59 PM, Jakub Jelinek wrote: > > > On Sun, Mar 22, 2015 at 11:11:24PM +0100, Jan Hubicka wrote: > > >> --- testsuite/g++.dg/lto/pr65475b_0.C (revision 0) > > >> +++ testsuite/g++.dg/lto/pr65475b_0.C (rev

Re: Fix ICEs on ODR violating programs and improve ODR mismatch diagnostic

2015-03-23 Thread Jakub Jelinek
On Mon, Mar 23, 2015 at 04:07:10PM +0100, Richard Biener wrote: > On Mon, Mar 23, 2015 at 3:59 PM, Jakub Jelinek wrote: > > On Sun, Mar 22, 2015 at 11:11:24PM +0100, Jan Hubicka wrote: > >> --- testsuite/g++.dg/lto/pr65475b_0.C (revision 0) > >> +++ testsuite/g++.dg/lto/pr65475b_0.C (revision 0) >

Re: Fix ICEs on ODR violating programs and improve ODR mismatch diagnostic

2015-03-23 Thread Richard Biener
On Mon, Mar 23, 2015 at 3:59 PM, Jakub Jelinek wrote: > On Sun, Mar 22, 2015 at 11:11:24PM +0100, Jan Hubicka wrote: >> --- testsuite/g++.dg/lto/pr65475b_0.C (revision 0) >> +++ testsuite/g++.dg/lto/pr65475b_0.C (revision 0) >> @@ -0,0 +1,9 @@ >> +/* { dg-lto-do link } */ >> +/* { dg-options "-O2

Re: Fix ICEs on ODR violating programs and improve ODR mismatch diagnostic

2015-03-23 Thread Jakub Jelinek
On Sun, Mar 22, 2015 at 11:11:24PM +0100, Jan Hubicka wrote: > --- testsuite/g++.dg/lto/pr65475b_0.C (revision 0) > +++ testsuite/g++.dg/lto/pr65475b_0.C (revision 0) > @@ -0,0 +1,9 @@ > +/* { dg-lto-do link } */ > +/* { dg-options "-O2 -Wno-odr" } */ Wasn't this supposed to be dg-lto-options ins

Re: Fix ICEs on ODR violating programs and improve ODR mismatch diagnostic

2015-03-23 Thread Jakub Jelinek
On Sun, Mar 22, 2015 at 11:11:24PM +0100, Jan Hubicka wrote: > PR ipa/65475 > * ipa-devirt.c: Include demangle.h > === > --- ipa-devirt.c (revision 221572) > +++ ipa-devirt.c (working copy) > @@ -166,6 +166,7 @@

Re: Fix ICEs on ODR violating programs and improve ODR mismatch diagnostic

2015-03-23 Thread Andreas Schwab
Jan Hubicka writes: > * ipa-devirt.c: Include demangle.h This breaks ada. ../libiberty/libiberty.a(cplus-dem.o): In function `ada_demangle': /usr/local/gcc/gcc-20150323/Build/libiberty/../../libiberty/cplus-dem.c:895: multiple definition of `ada_demangle' ada/adadecode.o:/usr/local/gcc/g

Fix ICEs on ODR violating programs and improve ODR mismatch diagnostic

2015-03-22 Thread Jan Hubicka
Hi, this patch fixes ODR violation warnings on Chromium and firefox. I went through all of them and found two false positives. I also fixes two ICEs that are triggered by testcases martin found while delta reducing. I tested the patch on firefox,chromium and libreoffice. Martin gave it a try on