Re: Dump framework newline cleanup

2013-09-17 Thread Richard Biener
On Mon, Sep 16, 2013 at 8:36 PM, Teresa Johnson wrote: > Yep, looked too quickly every time and thought the newline after "be > zero" was applying. Here is the patch with the fix. Ok for trunk > pending regression testing? Ok. Thanks, Richard. > 2013-09-16 Teresa Johnson > > * covera

Re: Dump framework newline cleanup

2013-09-16 Thread Teresa Johnson
Yep, looked too quickly every time and thought the newline after "be zero" was applying. Here is the patch with the fix. Ok for trunk pending regression testing? 2013-09-16 Teresa Johnson * coverage.c (get_coverage_counts): Add missing newline. Index: coverage.c ==

Re: Dump framework newline cleanup

2013-09-16 Thread Xinliang David Li
Looks like there is one missing spot: @@ -349,7 +349,7 @@ get_coverage_counts (unsigned counter, u (flag_guess_branch_prob ? "file %s not found, execution counts estimated" < : "file %s not foun

Re: Dump framework newline cleanup

2013-09-16 Thread Teresa Johnson
On Mon, Sep 16, 2013 at 10:57 AM, Xinliang David Li wrote: > I noticed there are a couple of dump_printf_loc instances in > coverage.c not ended with newline. They should be fixed. I committed this change this morning as r202628. I believe I fixed all the dump_printf_loc calls (just double-checke

Re: Dump framework newline cleanup

2013-09-16 Thread Xinliang David Li
I noticed there are a couple of dump_printf_loc instances in coverage.c not ended with newline. They should be fixed. David On Tue, Sep 10, 2013 at 6:32 AM, Teresa Johnson wrote: > On Mon, Sep 9, 2013 at 9:55 PM, Xinliang David Li wrote: >> looks fine to me. >> >> In the long run, I wonder if t

Re: Dump framework newline cleanup

2013-09-13 Thread Richard Biener
On Mon, Sep 9, 2013 at 9:01 PM, Teresa Johnson wrote: > I've attached a patch that implements the cleanup of newline emission > by the new dump framework as discussed here: > > http://gcc.gnu.org/ml/gcc-patches/2013-08/msg01779.html > > Essentially, I have removed the leading newline emission from

Re: Dump framework newline cleanup

2013-09-10 Thread Teresa Johnson
On Mon, Sep 9, 2013 at 9:55 PM, Xinliang David Li wrote: > looks fine to me. > > In the long run, I wonder if the machinery in diagnostic messages can > be reused for opt-info dumping -- i.e., support different streams. It > has many nice features including %qD specifier for printing tree > decls.

Re: Dump framework newline cleanup

2013-09-09 Thread Xinliang David Li
looks fine to me. In the long run, I wonder if the machinery in diagnostic messages can be reused for opt-info dumping -- i.e., support different streams. It has many nice features including %qD specifier for printing tree decls. David On Mon, Sep 9, 2013 at 12:01 PM, Teresa Johnson wrote: > I'