Re: Chromium: LTO

2015-02-15 Thread Jan Hubicka
> Hi, > > > +symtab_node::iterate_direct_aliases (unsigned i, ipa_ref *&ref) > > +{ > > + ref_list.referring.iterate (i, &ref); > > + > > + if (ref && ref->use != IPA_REF_ALIAS) > > +return NULL; > > + > > + return ref; > > +} > > it seems a little weird the out arg can return a non alias,

Re: Chromium: LTO

2015-02-15 Thread Trevor Saunders
Hi, > +symtab_node::iterate_direct_aliases (unsigned i, ipa_ref *&ref) > +{ > + ref_list.referring.iterate (i, &ref); > + > + if (ref && ref->use != IPA_REF_ALIAS) > +return NULL; > + > + return ref; > +} it seems a little weird the out arg can return a non alias, and so if you only want t

Re: Chromium: LTO

2015-02-14 Thread Jan Hubicka
Hi, Maritn has notced that we spend a lot of time in simple cgraph/varpool predicates. The patch bellow reorganizes inlines so the fast paths get fast. > perf report: > > 18.79% lto1-wpa lto1 [.] > do_estimate_growth_1(cgraph_node*, void*) > 12.48% lto1-wp