On Thu, Jan 31, 2019 at 07:11:59PM -0500, Jason Merrill wrote:
> On 1/31/19 7:01 PM, Marek Polacek wrote:
> > + if (*jump_target && *jump_target == orig_jump)
>
> You shouldn't need to check that it's non-null, since the enclosing if
> established that orig_jump will be non-null. OK with that
On 1/31/19 7:01 PM, Marek Polacek wrote:
+ if (*jump_target && *jump_target == orig_jump)
You shouldn't need to check that it's non-null, since the enclosing if
established that orig_jump will be non-null. OK with that tweak.
Jason
Here we have switch (1) with body
if (1)
{
case 1:;
return = 1;
}
else
{
default:;
}
so we're looking for "case 1:", which we found in the then branch while
evaluating the COND_EXPR, so *jump_target is cleared. But it's followed
by a jumping statement so *j
