Re: C++ PATCH for c++/83820 - excessive attribute arguments not detected

2019-06-25 Thread Iain Sandoe
Hi Dominique, > On 25 Jun 2019, at 12:10, Dominique d'Humières wrote: > > On darwin* I see > > FAIL: g++.dg/cpp0x/gen-attrs-67.C -std=c++14 (test for excess errors) > FAIL: g++.dg/cpp0x/gen-attrs-67.C -std=c++17 (test for excess errors) > > This is caused by the additional error > > /opt/gc

Re: C++ PATCH for c++/83820 - excessive attribute arguments not detected

2019-06-25 Thread Dominique d'Humières
On darwin* I see FAIL: g++.dg/cpp0x/gen-attrs-67.C -std=c++14 (test for excess errors) FAIL: g++.dg/cpp0x/gen-attrs-67.C -std=c++17 (test for excess errors) This is caused by the additional error /opt/gcc/_clean/gcc/testsuite/g++.dg/cpp0x/gen-attrs-67.C:11:34: error: constructor priorities ar

Re: C++ PATCH for c++/83820 - excessive attribute arguments not detected

2019-06-17 Thread Marek Polacek
On Mon, Jun 17, 2019 at 09:50:51AM -0600, Martin Sebor wrote: > On 6/16/19 1:10 PM, Marek Polacek wrote: > > While messing with [[noreturn]] I also found out that we don't detect > > the case when an attribute specifier that takes no arguments contains > > an attribute-argument-clause. > > > > Boo

Re: C++ PATCH for c++/83820 - excessive attribute arguments not detected

2019-06-17 Thread Jason Merrill
Ok. On Sun, Jun 16, 2019, 3:10 PM Marek Polacek wrote: > While messing with [[noreturn]] I also found out that we don't detect > the case when an attribute specifier that takes no arguments contains > an attribute-argument-clause. > > Bootstrapped/regtested on x86_64-linux, ok for trunk? > > 201

Re: C++ PATCH for c++/83820 - excessive attribute arguments not detected

2019-06-17 Thread Martin Sebor
On 6/16/19 1:10 PM, Marek Polacek wrote: While messing with [[noreturn]] I also found out that we don't detect the case when an attribute specifier that takes no arguments contains an attribute-argument-clause. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2019-06-16 Marek Polacek

C++ PATCH for c++/83820 - excessive attribute arguments not detected

2019-06-16 Thread Marek Polacek
While messing with [[noreturn]] I also found out that we don't detect the case when an attribute specifier that takes no arguments contains an attribute-argument-clause. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2019-06-16 Marek Polacek PR c++/83820 - excessive attribute a