Re: C++ PATCH for c++/52377 (NSDMI and unions)

2013-06-07 Thread Rainer Orth
Jason Merrill writes: > On 05/31/2013 07:13 AM, Rainer Orth wrote: >> Also, both testcases are missing from gcc/testsuite/ChangeLog. > > I prefer not to mess with logging testcase changes. > > http://gcc.gnu.org/codingconventions.html#ChangeLogs I hadn't seen this before. I think this policy is

Re: C++ PATCH for c++/52377 (NSDMI and unions)

2013-05-31 Thread Jason Merrill
On 05/31/2013 07:13 AM, Rainer Orth wrote: Is this really intended to be a run test? Oops, no, thanks. Also, both testcases are missing from gcc/testsuite/ChangeLog. I prefer not to mess with logging testcase changes. http://gcc.gnu.org/codingconventions.html#ChangeLogs Jason

Re: C++ PATCH for c++/52377 (NSDMI and unions)

2013-05-31 Thread Rainer Orth
Jason Merrill writes: > sort_mem_initializers was skipping over all fields without a > mem-initializer, even ones with an NSDMI. One of the testcases doesn't compile on Solaris 10/x86: output is: /vol/gcc/src/hg/trunk/local/gcc/testsuite/g++.dg/cpp0x/nsdmi-union2.C:4:7: error: multiple fields

C++ PATCH for c++/52377 (NSDMI and unions)

2013-05-30 Thread Jason Merrill
sort_mem_initializers was skipping over all fields without a mem-initializer, even ones with an NSDMI. Tested x86_64-pc-linux-gnu, applying to trunk. commit 25b01320a7aefae42d9e14f3807247ca8f88ae40 Author: Jason Merrill Date: Sat May 25 17:28:15 2013 -0400 PR c++/52377 * class.c (c