Re: C++ PATCH for c++/48446 (ICE with VLA)

2011-05-06 Thread Jason Merrill
I noticed a minor tweak I could make to speed this up and figure I might as well, even though it shouldn't be a significant component of compile time. Tested x86_64-pc-linux-gnu, applying to trunk and 4.6. commit 4c3e6de3e988799dac490b6eb2b762674b5bb9f8 Author: Jason Merrill Date: Thu May 5

Re: C++ PATCH for c++/48446 (ICE with VLA)

2011-05-02 Thread Jason Merrill
On 04/14/2011 10:52 AM, Jason Merrill wrote: This patch avoids this issue by saving bounds values which have side effects into a local automatic variable (since VLAs can only appear in automatic variables). We stick with the SAVE_EXPR approach for bounds without side-effects to avoid breaking vla

C++ PATCH for c++/48446 (ICE with VLA)

2011-04-14 Thread Jason Merrill
The issue here was that with a complex expression in DECL_SIZE for z, when wrap_cleanups tried to protect the initializer of m it walked into the sizeof and thus the bounds expression, which it really shouldn't be messing with. This patch avoids this issue by saving bounds values which have si