Re: Adjust omp-low test for alignment

2012-02-01 Thread Andreas Krebbel
On Sat, Nov 26, 2011 at 04:05:08PM -0800, Richard Henderson wrote: > The m68k-linux failure for the various omp atomic tests > is due to the fact that BIGGEST_ALIGNMENT is 16 bits on > that platform. I think it's pretty reasonable to assume > that if something is aligned to BIGGEST_ALIGNEMENT, the

Re: Adjust omp-low test for alignment

2011-12-02 Thread Hans-Peter Nilsson
On Fri, 2 Dec 2011, Mikael Pettersson wrote: > but futexes must be 32-bit aligned (or at least not cross page > boundaries). Don't mix up futexes with hardware-mandated atomic alignment (except that preferably the letter should not be more strict). Linux futexes must be 32-bit aligned *for all ar

Re: Adjust omp-low test for alignment

2011-12-02 Thread Mikael Pettersson
Hans-Peter Nilsson writes: > BTW, on the topic, I cringe whenever I > see futexes expressed as plain "int", they absolutely have to > have at least natural alignment which is not always true e.g. in > structs. People, please keep the atomic types > target-overridable in libraries. +1 for m

Re: Adjust omp-low test for alignment

2011-12-02 Thread Hans-Peter Nilsson
On Tue, 29 Nov 2011, Hans-Peter Nilsson wrote: > On Tue, 29 Nov 2011, Richard Henderson wrote: > > On 11/28/2011 08:49 PM, Hans-Peter Nilsson wrote: > > > On Sat, 26 Nov 2011, Richard Henderson wrote: > > >> The m68k-linux failure for the various omp atomic tests > > >> is due to the fact that BIG

Re: Adjust omp-low test for alignment

2011-11-29 Thread Hans-Peter Nilsson
On Tue, 29 Nov 2011, Richard Henderson wrote: > On 11/28/2011 08:49 PM, Hans-Peter Nilsson wrote: > > On Sat, 26 Nov 2011, Richard Henderson wrote: > >> The m68k-linux failure for the various omp atomic tests > >> is due to the fact that BIGGEST_ALIGNMENT is 16 bits on > >> that platform. I think

Re: Adjust omp-low test for alignment

2011-11-29 Thread Richard Henderson
On 11/28/2011 08:49 PM, Hans-Peter Nilsson wrote: > On Sat, 26 Nov 2011, Richard Henderson wrote: >> The m68k-linux failure for the various omp atomic tests >> is due to the fact that BIGGEST_ALIGNMENT is 16 bits on >> that platform. I think it's pretty reasonable to assume >> that if something is

Re: Adjust omp-low test for alignment

2011-11-28 Thread Hans-Peter Nilsson
On Sat, 26 Nov 2011, Richard Henderson wrote: > The m68k-linux failure for the various omp atomic tests > is due to the fact that BIGGEST_ALIGNMENT is 16 bits on > that platform. I think it's pretty reasonable to assume > that if something is aligned to BIGGEST_ALIGNEMENT, then > it can be conside

Adjust omp-low test for alignment

2011-11-26 Thread Richard Henderson
The m68k-linux failure for the various omp atomic tests is due to the fact that BIGGEST_ALIGNMENT is 16 bits on that platform. I think it's pretty reasonable to assume that if something is aligned to BIGGEST_ALIGNEMENT, then it can be considered "aligned". Tested on x86_64-linux and m68k-linux cr