Re: Add value_range_base::contains_p

2019-06-13 Thread Richard Biener
On Wed, Jun 12, 2019 at 11:33 PM Aldy Hernandez wrote: > > On 6/12/19 5:33 AM, Richard Biener wrote: > > On Wed, Jun 12, 2019 at 1:57 AM Martin Sebor wrote: > >> > >> On 6/11/19 3:02 PM, Aldy Hernandez wrote: > >>> > >>> > >>> On 6/11/19 12:52 PM, Martin Sebor wrote: > On 6/11/19 10:26 AM, A

Re: Add value_range_base::contains_p

2019-06-12 Thread Aldy Hernandez
On 6/12/19 5:33 AM, Richard Biener wrote: On Wed, Jun 12, 2019 at 1:57 AM Martin Sebor wrote: On 6/11/19 3:02 PM, Aldy Hernandez wrote: On 6/11/19 12:52 PM, Martin Sebor wrote: On 6/11/19 10:26 AM, Aldy Hernandez wrote: On 6/11/19 12:17 PM, Martin Sebor wrote: On 6/11/19 9:05 AM, Aldy

Re: Add value_range_base::contains_p

2019-06-12 Thread Richard Biener
On Wed, Jun 12, 2019 at 1:57 AM Martin Sebor wrote: > > On 6/11/19 3:02 PM, Aldy Hernandez wrote: > > > > > > On 6/11/19 12:52 PM, Martin Sebor wrote: > >> On 6/11/19 10:26 AM, Aldy Hernandez wrote: > >>> > >>> > >>> On 6/11/19 12:17 PM, Martin Sebor wrote: > On 6/11/19 9:05 AM, Aldy Hernande

Re: Add value_range_base::contains_p

2019-06-11 Thread Martin Sebor
On 6/11/19 3:02 PM, Aldy Hernandez wrote: On 6/11/19 12:52 PM, Martin Sebor wrote: On 6/11/19 10:26 AM, Aldy Hernandez wrote: On 6/11/19 12:17 PM, Martin Sebor wrote: On 6/11/19 9:05 AM, Aldy Hernandez wrote: On 6/11/19 9:45 AM, Richard Biener wrote: On Tue, Jun 11, 2019 at 12:40 PM Ald

Re: Add value_range_base::contains_p

2019-06-11 Thread Aldy Hernandez
On 6/11/19 12:52 PM, Martin Sebor wrote: On 6/11/19 10:26 AM, Aldy Hernandez wrote: On 6/11/19 12:17 PM, Martin Sebor wrote: On 6/11/19 9:05 AM, Aldy Hernandez wrote: On 6/11/19 9:45 AM, Richard Biener wrote: On Tue, Jun 11, 2019 at 12:40 PM Aldy Hernandez wrote: This patch cleans u

Re: Add value_range_base::contains_p

2019-06-11 Thread Martin Sebor
On 6/11/19 10:26 AM, Aldy Hernandez wrote: On 6/11/19 12:17 PM, Martin Sebor wrote: On 6/11/19 9:05 AM, Aldy Hernandez wrote: On 6/11/19 9:45 AM, Richard Biener wrote: On Tue, Jun 11, 2019 at 12:40 PM Aldy Hernandez wrote: This patch cleans up the various contains, may_contain, and valu

Re: Add value_range_base::contains_p

2019-06-11 Thread Aldy Hernandez
On 6/11/19 12:17 PM, Martin Sebor wrote: On 6/11/19 9:05 AM, Aldy Hernandez wrote: On 6/11/19 9:45 AM, Richard Biener wrote: On Tue, Jun 11, 2019 at 12:40 PM Aldy Hernandez wrote: This patch cleans up the various contains, may_contain, and value_inside_range variants we have throughout,

Re: Add value_range_base::contains_p

2019-06-11 Thread Martin Sebor
On 6/11/19 9:05 AM, Aldy Hernandez wrote: On 6/11/19 9:45 AM, Richard Biener wrote: On Tue, Jun 11, 2019 at 12:40 PM Aldy Hernandez wrote: This patch cleans up the various contains, may_contain, and value_inside_range variants we have throughout, in favor of one-- contains_p.  There should

Re: Add value_range_base::contains_p

2019-06-11 Thread Aldy Hernandez
On 6/11/19 9:45 AM, Richard Biener wrote: On Tue, Jun 11, 2019 at 12:40 PM Aldy Hernandez wrote: This patch cleans up the various contains, may_contain, and value_inside_range variants we have throughout, in favor of one-- contains_p. There should be no changes in functionality. I have add

Re: Add value_range_base::contains_p

2019-06-11 Thread Richard Biener
On Tue, Jun 11, 2019 at 12:40 PM Aldy Hernandez wrote: > > This patch cleans up the various contains, may_contain, and > value_inside_range variants we have throughout, in favor of one-- > contains_p. There should be no changes in functionality. > > I have added a note to range_includes_zero_p, p

Add value_range_base::contains_p

2019-06-11 Thread Aldy Hernandez
This patch cleans up the various contains, may_contain, and value_inside_range variants we have throughout, in favor of one-- contains_p. There should be no changes in functionality. I have added a note to range_includes_zero_p, perhaps as a personal question than anything else. This functio