Re: [v3 PATCH] PR libstdc++/87619

2018-10-17 Thread Jonathan Wakely
On 17/10/18 15:06 +0300, Ville Voutilainen wrote: On Wed, 17 Oct 2018 at 12:20, Ville Voutilainen wrote: On Wed, 17 Oct 2018 at 12:07, Jonathan Wakely wrote: > It might be worth also calling f<256>() and doing: > > template > void f_impl(std::index_sequence is) > { > using V = std::variant

Re: [v3 PATCH] PR libstdc++/87619

2018-10-17 Thread Ville Voutilainen
On Wed, 17 Oct 2018 at 12:20, Ville Voutilainen wrote: > > On Wed, 17 Oct 2018 at 12:07, Jonathan Wakely wrote: > > It might be worth also calling f<256>() and doing: > > > > template > > void f_impl(std::index_sequence is) > > { > > using V = std::variant...>; > > > > // For a variant of 25

Re: [v3 PATCH] PR libstdc++/87619

2018-10-17 Thread Ville Voutilainen
On Wed, 17 Oct 2018 at 12:07, Jonathan Wakely wrote: > It might be worth also calling f<256>() and doing: > > template > void f_impl(std::index_sequence is) > { > using V = std::variant...>; > > // For a variant of 255 alternatives the valid indices are [0,254] > // and index 255 means valu

Re: [v3 PATCH] PR libstdc++/87619

2018-10-17 Thread Jonathan Wakely
On 16/10/18 22:59 +0300, Ville Voutilainen wrote: Simple, short, and sweet, just a thinko. 2018-10-16 Ville Voutilainen PR libstdc++/87619 * include/std/variant (__select_index): Fix an off-by-one. * testsuite/20_util/variant/87619.cc: New. diff --git a/libstdc++-v3/include/std/v

[v3 PATCH] PR libstdc++/87619

2018-10-16 Thread Ville Voutilainen
Simple, short, and sweet, just a thinko. 2018-10-16 Ville Voutilainen PR libstdc++/87619 * include/std/variant (__select_index): Fix an off-by-one. * testsuite/20_util/variant/87619.cc: New. diff --git a/libstdc++-v3/include/std/variant b/libstdc++-v3/include/std/variant index 2d86