Re: [v3 PATCH] Implement C++17 make_from_tuple.

2016-08-15 Thread Jonathan Wakely
On 11/08/16 03:04 +0300, Ville Voutilainen wrote: + + template +constexpr _Tp +__make_from_tuple_impl(_Tuple&& __t, index_sequence<_Idx...>) +{ return _Tp(get<_Idx>(std::forward<_Tuple>(__t))...); } We need to use std::get here. + + template +constexpr _Tp +make_from_t

Re: [v3 PATCH] Implement C++17 make_from_tuple.

2016-08-15 Thread Jonathan Wakely
On 14/08/16 21:27 +0300, Ville Voutilainen wrote: Here. Tested on Linux-x64. I made the test for the macro value compare it relatively rather than exactly; I don't think our tests should necessarily break just because a macro value is updated. 2016-08-14 Ville Voutilainen Add a feature ma

Re: [v3 PATCH] Implement C++17 make_from_tuple.

2016-08-14 Thread Ville Voutilainen
On 11 August 2016 at 21:05, Ville Voutilainen wrote: >> The latest SD-6 has a feature test macro; >> >> #define __cpp_lib_make_from_tuple 201606 >> >> >> Also the test should get: >> >> #ifndef __cpp_lib_make_from_tuple >> # error "Feature-test macro for make_from_tuple missing" >> #elif __cpp_li

Re: [v3 PATCH] Implement C++17 make_from_tuple.

2016-08-11 Thread Ville Voutilainen
On 11 August 2016 at 20:45, Ed Smith-Rowland <3dw...@verizon.net> wrote: > On 08/10/2016 08:04 PM, Ville Voutilainen wrote: > > I was in the middle of doing this, so here's the patch before I commit > the string_view one. > > Tested on Linux-x64. > > 2016-08-11 Ville Voutilainen > > Implemen

Re: [v3 PATCH] Implement C++17 make_from_tuple.

2016-08-11 Thread Paolo Carlini
Hi, On 11/08/2016 02:04, Ville Voutilainen wrote: I was in the middle of doing this, so here's the patch before I commit the string_view one. Thanks. This one also looks straightforward enough to me. I'm still working on your largish contributions... Thanks again, Paolo.

[v3 PATCH] Implement C++17 make_from_tuple.

2016-08-10 Thread Ville Voutilainen
I was in the middle of doing this, so here's the patch before I commit the string_view one. Tested on Linux-x64. 2016-08-11 Ville Voutilainen Implement C++17 make_from_tuple. * include/std/tuple (__make_from_tuple_impl, make_from_tuple): New. * testsuite/20_util/tuple/make_from_tu