Re: [v3] More noexcept for vectors

2013-09-16 Thread Paolo Carlini
On 09/16/2013 07:32 PM, Marc Glisse wrote: New version that passed testing. Looks good to me, thanks! Paolo.

Re: [v3] More noexcept for vectors

2013-09-16 Thread Marc Glisse
New version that passed testing. 2013-09-16 Marc Glisse PR libstdc++/58338 * include/bits/stl_vector.h (vector::vector(), vector::vector(const allocator_type&)): Merge. (_Vector_impl::_Vector_impl(_Tp_alloc_type const&), _Vector_impl::_Vector_impl(_Tp_a

Re: [v3] More noexcept for vectors

2013-09-16 Thread Marc Glisse
On Mon, 16 Sep 2013, Jonathan Wakely wrote: Are you sure the noexcept on the destructors is useless? Ok, I am putting it back in. -- Marc Glisse

Re: [v3] More noexcept for vectors

2013-09-16 Thread Jonathan Wakely
On 15 September 2013 10:12, Marc Glisse wrote: > > PR libstdc++/58338 > * include/bits/stl_vector.h > (_Vector_impl::_Vector_impl(_Tp_alloc_type const&), > _Vector_impl::_Vector_impl(_Tp_alloc_type&&), > _Vector_impl::_M_swap_data, > _Vector_base::_Ve

Re: [v3] More noexcept for vectors

2013-09-16 Thread Marc Glisse
On Mon, 16 Sep 2013, Paolo Carlini wrote: On 09/15/2013 11:12 AM, Marc Glisse wrote: I had to separate the constructor that takes an allocator from the default constructor in debug/profile, since in release the noexcept only applies to one of them (and the testsuite asserts that release and de

Re: [v3] More noexcept for vectors

2013-09-16 Thread Paolo Carlini
Hi Marc, On 09/15/2013 11:12 AM, Marc Glisse wrote: I had to separate the constructor that takes an allocator from the default constructor in debug/profile, since in release the noexcept only applies to one of them (and the testsuite asserts that release and debug agree on this). An alternativ

Re: [v3] More noexcept for vectors

2013-09-15 Thread Marc Glisse
I had to separate the constructor that takes an allocator from the default constructor in debug/profile, since in release the noexcept only applies to one of them (and the testsuite asserts that release and debug agree on this). An alternative would be to make the release vector default constru

Re: [v3] More noexcept for vectors

2013-09-14 Thread Paolo Carlini
Hi, >I was going one file at a time, and the priority is clearly >"release"-mode, since this is about performance. I don't think there is > >anything wrong with debug-mode having a different exception >specification >(it is already binary-incompatible with the default mode) but I >understand >w

Re: [v3] More noexcept for vectors

2013-09-14 Thread Marc Glisse
On Sat, 14 Sep 2013, Paolo Carlini wrote: ... what about debug-mode (and profile-mode)? Is in principle possible to detect the noexcepts? If we can't exclude that, we should probably change at the same time the special modes too. Otherwise seems just matter of consistency? I was going one fi

Re: [v3] More noexcept for vectors

2013-09-14 Thread Paolo Carlini
... what about debug-mode (and profile-mode)? Is in principle possible to detect the noexcepts? If we can't exclude that, we should probably change at the same time the special modes too. Otherwise seems just matter of consistency? Paolo

Re: [v3] More noexcept for vectors

2013-09-14 Thread Paolo Carlini
Hi, Marc Glisse ha scritto: >Hello, > >this patch passes bootstrap+testsuite. The guarantees given by the >standard on allocators are a bit weird, but I see there is already >DR2016 >taking care of it. Patch looks good to me, thanks! Paolo

[v3] More noexcept for vectors

2013-09-14 Thread Marc Glisse
Hello, this patch passes bootstrap+testsuite. The guarantees given by the standard on allocators are a bit weird, but I see there is already DR2016 taking care of it. 2013-09-14 Marc Glisse PR libstdc++/58338 * include/bits/stl_vector.h (_Vector_impl::_Vector_impl(