Re: [trunk][RFA] Add __i686.get_pc_thunk.bx to libgcc i386 morestack.S

2011-05-04 Thread Chris Demetriou
On Wed, May 4, 2011 at 00:52, Chris Demetriou wrote: > Ian, per your previous comment (which I read as pre-approval for this > change 8-), I'm planning to commit the attached as soon as it's done > testing. > > > chris > - > [libgcc/ChangeLog] > 2011-05-04  Chris Demetriou   > >        * confi

Re: [trunk][RFA] Add __i686.get_pc_thunk.bx to libgcc i386 morestack.S

2011-05-04 Thread Chris Demetriou
On Tue, May 3, 2011 at 16:39, Chris Demetriou wrote: > > It is also OK if you s/__i686/__x86/ to correspond to your earlier > > change.  Either way is OK. > > Well, that change is not in trunk. > Should that change move to trunk, yes, it's appropriate to change this > as well (though strictly not

Re: [trunk][RFA] Add __i686.get_pc_thunk.bx to libgcc i386 morestack.S

2011-05-03 Thread Chris Demetriou
On Tue, May 3, 2011 at 15:05, Ian Lance Taylor wrote: > > > 2011-05-03  Chris Demetriou   > > > >         * libgcc/config/i386/morestack.S (__i686.get_pc_thunk.bx): New. > > No "libgcc" in libgcc/ChangeLog. Fixed, sorry.  (That's what I get for pasting from svn status output.  8-) > It is also O

Re: [trunk][RFA] Add __i686.get_pc_thunk.bx to libgcc i386 morestack.S

2011-05-03 Thread Ian Lance Taylor
Chris Demetriou writes: > 2011-05-03 Chris Demetriou > > * libgcc/config/i386/morestack.S (__i686.get_pc_thunk.bx): New. No "libgcc" in libgcc/ChangeLog. This is OK. It is also OK if you s/__i686/__x86/ to correspond to your earlier change. Either way is OK. Thanks. Ian

[trunk][RFA] Add __i686.get_pc_thunk.bx to libgcc i386 morestack.S

2011-05-03 Thread Chris Demetriou
After I submitted http://gcc.gnu.org/ml/gcc-patches/2011-04/msg02422.html, Rong Xu noted that the resulting sources, if configured --with-pic, would not actually build properly due to missing __i686.get_pc_thunk.bx (due to my renaming that to __x86...). While that issue was exposed by my change, i