Re: [rtl] Harden 'set_noop_p' for non-constant selectors [PR94279]

aybe really specific to (or, exposed by) AMD GCN's vector >>> instructions? (For AMD GCN offloading, we only care about master >>> branch.) >> >> I don't think it's needed prior to GCC 9, and then only for amdgcn which >> was probably not wi

Re: [rtl] Harden 'set_noop_p' for non-constant selectors [PR94279]

Andrew Stubbs writes: > On 22/04/2020 17:43, Thomas Schwinge wrote: >> In "[amdgcn] internal compiler error: RTL >> check: expected code 'const_int', have 'reg' in rtx_to_poly_int64, at >> rtl.h:2379", we recently found that that it's wrong to expect constant >> selec

Re: [rtl] Harden 'set_noop_p' for non-constant selectors [PR94279]

On 22/04/2020 17:43, Thomas Schwinge wrote: In "[amdgcn] internal compiler error: RTL check: expected code 'const_int', have 'reg' in rtx_to_poly_int64, at rtl.h:2379", we recently found that that it's wrong to expect constant selectors, at least in the current code

[rtl] Harden 'set_noop_p' for non-constant selectors [PR94279] (was: [Patch, RTL] Eliminate redundant vec_select moves)

original code (as quoted above) is actually buggy already, but it already does contain the pattern that 'INTVAL' is used on something without making sure that we're actually dealing with a constant selector. (Has that maybe have been an impossible scenario back then?) Anyway. At