Re: [pph] Prepare for mutation detection [3/3] (issue5139052)

2011-10-04 Thread Diego Novillo
On Wed, Sep 28, 2011 at 17:28, Gabriel Charette wrote: > Very nice! > > I really like where this is heading :)! > > I think it would be great to instrument this to know how many times we > need to use a PPH_RECORD_MREF, to avoid trashing the cache (i.e. > potentially there are specific cases where

Re: [pph] Prepare for mutation detection [3/3] (issue5139052)

2011-09-28 Thread Gabriel Charette
Very nice! I really like where this is heading :)! I think it would be great to instrument this to know how many times we need to use a PPH_RECORD_MREF, to avoid trashing the cache (i.e. potentially there are specific cases where only a small field's value changes and pickling the entire tree aga

[pph] Prepare for mutation detection [3/3] (issue5139052)

2011-09-27 Thread Diego Novillo
This finishes removing constants and builtins out of the cache. This time in a slightly more elegant way. The patch introduces a new version of pph_out_start_record exclusively for trees (pph_out_start_tree_record). If the tree is not cacheable then it emits a PPH_RECORD_START_NO_CACHE record to