Re: [pph] Initialize cache_ix in all paths in pph_start_record (issue4642045)

2011-06-22 Thread dnovillo
On 2011/06/18 01:29:31, Gabriel Charette wrote: 2011-06-17 Gabriel Charette * gcc/cp/pph-streamer-in.c (pph_start_record): Initialize cache_ix in all paths. OK. Applied to branch. Diego. http://codereview.appspot.com/4642045/

[pph] Initialize cache_ix in all paths in pph_start_record (issue4642045)

2011-06-17 Thread Gabriel Charette
Clarified comment from v1 of this patch. 2011-06-17 Gabriel Charette * gcc/cp/pph-streamer-in.c (pph_start_record): Initialize cache_ix in all paths. diff --git a/gcc/cp/pph-streamer-in.c b/gcc/cp/pph-streamer-in.c index b3c2ac9..186100f 100644 --- a/gcc/cp/pph-streamer-in.c +

[pph] Initialize cache_ix in all paths in pph_start_record (issue4642045)

2011-06-17 Thread Gabriel Charette
Read the comment in the diff for all the details. I found this while working on my current patch, adding some assertion at the end of the function would create a new build error and moving it around in the function would stop showing the error. I discussed this with Collin and Jeff and it appears