Re: [pph] Independent pre-loaded cache for common nodes (issue 4956041)

2011-08-25 Thread Diego Novillo
On Thu, Aug 25, 2011 at 13:17, Gabriel Charette wrote: > What do you mean? the || is aligned with the 'marker' entry above it. > Do you want the || to be aligned? i.e. > marker == PPH_RECORD_IREF > || marker == PPH_RECORD_XREF > || marker == PPH_RECORD_PREF > ? Yeah, this way. Every operand of

Re: [pph] Independent pre-loaded cache for common nodes (issue 4956041)

2011-08-25 Thread dnovillo
OK with a couple of nits below. Diego. http://codereview.appspot.com/4956041/diff/1/gcc/cp/pph-streamer-in.c File gcc/cp/pph-streamer-in.c (right): http://codereview.appspot.com/4956041/diff/1/gcc/cp/pph-streamer-in.c#newcode155 gcc/cp/pph-streamer-in.c:155: || marker == PPH_RECORD_PREF; 154