Re: [pph] Fix cxx_binding streaming logic (issue4646041)

2011-06-17 Thread Diego Novillo
On Thu, Jun 16, 2011 at 18:57, Gabriel Charette wrote: > At the end of pph_out_cxx_binding I could also simply do > pph_out_uchar (stream, PPH_RECORD_END); > instead of > pph_out_cxx_binding_1 (stream, NULL, ref_p); > which has the exact same effect. That's fine. I kind of prefer the way you di

[pph] Fix cxx_binding streaming logic (issue4646041)

2011-06-16 Thread Gabriel Charette
We were losing bindings when reassigning prev bindings with the current streaming logic. This doesn't fix any currently exposed bugs, but again helps me as part of fixing the bigger bug I'm on. Tested with bootstrap build and pph regression testing. At the end of pph_out_cxx_binding I could also