Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-03-01 Thread Kai Tietz
2012/3/1 Joseph S. Myers : > On Thu, 1 Mar 2012, Kai Tietz wrote: > >> 2012-03-01  Kai Tietz   >> >>       * soft-fp: Imported from glibc upstream. >> >> Ok for apply ? > > If this is just copying the files from glibc, then it's OK for GCC. Yes, it is. Applied at rev 184760. Thanks, Kai

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-03-01 Thread Joseph S. Myers
On Thu, 1 Mar 2012, Kai Tietz wrote: > 2012-03-01 Kai Tietz > > * soft-fp: Imported from glibc upstream. > > Ok for apply ? If this is just copying the files from glibc, then it's OK for GCC. -- Joseph S. Myers jos...@codesourcery.com

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-03-01 Thread Joseph S. Myers
On Thu, 1 Mar 2012, Kai Tietz wrote: > Well, there are some new files, which aren't present in gcc's copy. They are not new files. They are files that were in soft-fp all along but weren't imported into GCC because they aren't relevant to GCC. > The rest of the changes are just related to the

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-03-01 Thread Kai Tietz
2012/3/1 Joseph S. Myers : > On Thu, 1 Mar 2012, Kai Tietz wrote: > >> As I understand the README file in soft-fp, just those files affected >> by my patch need to be merged from glibc. > > It's better to import the lot, rather than have mixed versions.  (But if > there are non-comment changes to f

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-03-01 Thread Joseph S. Myers
On Thu, 1 Mar 2012, Kai Tietz wrote: > As I understand the README file in soft-fp, just those files affected > by my patch need to be merged from glibc. It's better to import the lot, rather than have mixed versions. (But if there are non-comment changes to files not affected by your patch, it

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-03-01 Thread Kai Tietz
Hello, Thanks and sorry for the troubles I caused. Next time I will prepare patches for it against glibc's developer repository. As I understand the README file in soft-fp, just those files affected by my patch need to be merged from glibc. As the mingw targets are using by defaul ms-struct lay

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-03-01 Thread Joseph S. Myers
On Thu, 1 Mar 2012, Kai Tietz wrote: > 2012/3/1 Joseph S. Myers : > > On Thu, 1 Mar 2012, Kai Tietz wrote: > > > >> Thanks, I adjusted ChangeLog, comment, and added the copyright year. > >> It would be kind, if somebody could apply this patch to glibc's > >> repository as I don't have commit acces

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-03-01 Thread Kai Tietz
2012/3/1 Joseph S. Myers : > On Thu, 1 Mar 2012, Kai Tietz wrote: > >> Thanks, I adjusted ChangeLog, comment, and added the copyright year. >> It would be kind, if somebody could apply this patch to glibc's >> repository as I don't have commit access to it.  I can do the applying >> to gcc's tree,

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-03-01 Thread Joseph S. Myers
On Thu, 1 Mar 2012, Kai Tietz wrote: > Thanks, I adjusted ChangeLog, comment, and added the copyright year. > It would be kind, if somebody could apply this patch to glibc's > repository as I don't have commit access to it. I can do the applying > to gcc's tree, if patch is ok-ed. This patch doe

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-03-01 Thread Kai Tietz
2012/2/27 Joseph S. Myers : > On Mon, 27 Feb 2012, Kai Tietz wrote: > >> 2012-02-28  Kai Tietz   >> >>       * soft-fp/soft-fp.h (_FP_STRUCT_LAYOUT): If not defined, >>       define it as empty macro. >>       * soft-fp/quad.h: Mark bitfield-structures by _FP_STRUCT_LAYOUT. >>       * soft-fp/exten

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-02-28 Thread Richard Henderson
On 02/27/12 09:22, Kai Tietz wrote: > 2012-02-28 Kai Tietz > > * config/i386/sfp-machine.h (_FP_STRUCT_LAYOUT): Define it > for mingw-targets as attribute gcc_struct. This is ok. r~

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-02-27 Thread Joseph S. Myers
On Mon, 27 Feb 2012, Kai Tietz wrote: > 2012-02-28 Kai Tietz > > * soft-fp/soft-fp.h (_FP_STRUCT_LAYOUT): If not defined, > define it as empty macro. > * soft-fp/quad.h: Mark bitfield-structures by _FP_STRUCT_LAYOUT. > * soft-fp/extended.h: Likewise. > * soft-fp/s

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-02-27 Thread Kai Tietz
So here is the libgcc patch only. ChangeLog gcc's libgcc 2012-02-28 Kai Tietz * config/i386/sfp-machine.h (_FP_STRUCT_LAYOUT): Define it for mingw-targets as attribute gcc_struct. Ok for apply? Regards, Kai Index: config/i386/sfp-machine.h ==

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-02-27 Thread Kai Tietz
2012/2/27 Joseph S. Myers : > On Mon, 27 Feb 2012, Kai Tietz wrote: > >> For gcc_struct variant bitfields with different types get merged >> together, but for ms_struct  bitfields are getting merged together >> only, if they have same type.  As in those structures - I modified in >> this patch - we

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-02-27 Thread Joseph S. Myers
On Mon, 27 Feb 2012, Kai Tietz wrote: > For gcc_struct variant bitfields with different types get merged > together, but for ms_struct bitfields are getting merged together > only, if they have same type. As in those structures - I modified in > this patch - we have varying types for bitfields,

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-02-27 Thread Kai Tietz
2012/2/27 Joseph S. Myers : > As explained in codingconventions.html, soft-fp is imported from glibc. > For files that come from glibc, you can only copy in the glibc versions, > unchanged. Ok, thanks for explaination. > Thus, you should submit this fix to libc-alpha.  You'll need to explain > wh

Re: [patch libgcc]: Fix float128 soft-float for mingw targets

2012-02-27 Thread Joseph S. Myers
On Mon, 27 Feb 2012, Kai Tietz wrote: > 2012-02-27 Kai Tietz > > * soft-fp/quad.h: Mark bitfield-structures as gcc_struct. > > Regression tested for i686-w64-mingw32, x86_64-w64-mingw32, and > x86_64-unknown-linux-gnu for all languages (including Ada + Obj-C++). > Ok for apply? As expl

[patch libgcc]: Fix float128 soft-float for mingw targets

2012-02-26 Thread Kai Tietz
Hi, by recent tests in gcc.target/i386 I noticed that testcase float128-2.c failed on executation. This failure is caused by incompatible bitfield-structure definition in soft-fp/quad.h for enabled ms-bitfields layout. Patch marks those structures to be 'gcc_struct' for mingw targets. ChangeLog