Re: [patch] various OpenACC reduction enhancements - FE changes

2018-12-18 Thread Jakub Jelinek
On Thu, Dec 13, 2018 at 02:11:31PM +, Julian Brown wrote: > > Any reason for the above (ditto in C), rather than just adding > > && ort != C_ORT_ACC to the while loop condition for CPP_OPEN_SQUARE? > > (, . or * after id-expression is like any other unhandled > > characters... > > I think the

Re: [patch] various OpenACC reduction enhancements - ME and nvptx changes

2018-12-13 Thread Julian Brown
On Tue, 4 Dec 2018 16:55:04 +0100 Tom de Vries wrote: > On 04-12-18 13:29, Jakub Jelinek wrote: > > On Fri, Jun 29, 2018 at 11:19:53AM -0700, Cesar Philippidis wrote: > >> The attached patch includes the nvptx and GCC ME reductions > >> enhancements. > >> > >> Is this patch OK for trunk? It boo

Re: [patch] various OpenACC reduction enhancements - test cases

2018-12-13 Thread Julian Brown
On Tue, 4 Dec 2018 13:59:33 +0100 Jakub Jelinek wrote: > On Fri, Jun 29, 2018 at 11:23:21AM -0700, Cesar Philippidis wrote: > > Attached are the updated reductions tests cases. Again, these have > > been bootstrapped and regression tested cleanly for x86_64 with > > nvptx offloading. Is it OK for

Re: [patch] various OpenACC reduction enhancements - FE changes

2018-12-13 Thread Julian Brown
On Tue, 4 Dec 2018 13:57:24 +0100 Jakub Jelinek wrote: > On Fri, Jun 29, 2018 at 11:22:00AM -0700, Cesar Philippidis wrote: > > 2018-06-29 Cesar Philippidis > > Nathan Sidwell > > > > gcc/c/ > > * c-parser.c (c_parser_omp_variable_list): New > > c_omp_region_type argument.

Re: [patch] various OpenACC reduction enhancements - ME and nvptx changes

2018-12-04 Thread Tom de Vries
On 04-12-18 13:29, Jakub Jelinek wrote: > On Fri, Jun 29, 2018 at 11:19:53AM -0700, Cesar Philippidis wrote: >> The attached patch includes the nvptx and GCC ME reductions enhancements. >> >> Is this patch OK for trunk? It bootstrapped / regression tested cleanly >> for x86_64 with nvptx offloading

Re: [patch] various OpenACC reduction enhancements - test cases

2018-12-04 Thread Jakub Jelinek
On Fri, Jun 29, 2018 at 11:23:21AM -0700, Cesar Philippidis wrote: > Attached are the updated reductions tests cases. Again, these have been > bootstrapped and regression tested cleanly for x86_64 with nvptx > offloading. Is it OK for trunk? If Thomas is ok with this, it is ok for trunk. > 2018-0

Re: [patch] various OpenACC reduction enhancements - FE changes

2018-12-04 Thread Jakub Jelinek
On Fri, Jun 29, 2018 at 11:22:00AM -0700, Cesar Philippidis wrote: > 2018-06-29 Cesar Philippidis > Nathan Sidwell > > gcc/c/ > * c-parser.c (c_parser_omp_variable_list): New c_omp_region_type > argument. Use it to specialize handling of OMP_CLAUSE_REDUCTION for >

Re: [patch] various OpenACC reduction enhancements - ME and nvptx changes

2018-12-04 Thread Jakub Jelinek
On Fri, Jun 29, 2018 at 11:19:53AM -0700, Cesar Philippidis wrote: > The attached patch includes the nvptx and GCC ME reductions enhancements. > > Is this patch OK for trunk? It bootstrapped / regression tested cleanly > for x86_64 with nvptx offloading. This is all OpenACC specific code not real

Re: [patch] various OpenACC reduction enhancements - ME and nvptx changes

2018-10-30 Thread Cesar Philippidis
On 10/5/18 07:07, Tom de Vries wrote: > On 6/29/18 8:19 PM, Cesar Philippidis wrote: >> The attached patch includes the nvptx and GCC ME reductions enhancements. >> >> Is this patch OK for trunk? It bootstrapped / regression tested cleanly >> for x86_64 with nvptx offloading. >> > > These need fix

Re: [patch] various OpenACC reduction enhancements - ME and nvptx changes

2018-10-05 Thread Tom de Vries
On 6/29/18 8:19 PM, Cesar Philippidis wrote: > The attached patch includes the nvptx and GCC ME reductions enhancements. > > Is this patch OK for trunk? It bootstrapped / regression tested cleanly > for x86_64 with nvptx offloading. > These need fixing: ... === ERROR type #5: trailing whitespace

Re: [patch] various OpenACC reduction enhancements - test cases

2018-06-29 Thread Cesar Philippidis
Attached are the updated reductions tests cases. Again, these have been bootstrapped and regression tested cleanly for x86_64 with nvptx offloading. Is it OK for trunk? Thanks, Cesar 2018-06-29 Cesar Philippidis Nathan Sidwell gcc/testsuite/ * c-c++-common/goacc/orphan-reductions-1.c:

Re: [patch] various OpenACC reduction enhancements - FE changes

2018-06-29 Thread Cesar Philippidis
Attaches are the FE changes for the OpenACC reduction enhancements. It depends on the ME patch. Is this patch OK for trunk? It bootstrapped / regression tested cleanly for x86_64 with nvptx offloading. Thanks, Cesar 2018-06-29 Cesar Philippidis Nathan Sidwell gcc/c/ * c-parser.c (c_p

Re: [patch] various OpenACC reduction enhancements - ME and nvptx changes

2018-06-29 Thread Cesar Philippidis
The attached patch includes the nvptx and GCC ME reductions enhancements. Is this patch OK for trunk? It bootstrapped / regression tested cleanly for x86_64 with nvptx offloading. Thanks, Cesar 2018-06-29 Cesar Philippidis Nathan Sidwell gcc/ * config/nvptx/nvptx.c (nvptx_propagate_u

[patch] various OpenACC reduction enhancements

2018-06-29 Thread Cesar Philippidis
The following patch set includes various OpenACC reduction enhancements present in og8. These include the following individual og8 commits: * (4469fc4) [Fortran] Permit reductions in gfc_omp_clause_copy_ctor * (704f1a2) [nxptx, OpenACC] vector reductions * (8a35c89) [OpenACC] Fix a reduction