On Fri, Dec 7, 2012 at 11:34 AM, Jakub Jelinek wrote:
> On Fri, Dec 07, 2012 at 11:25:38AM +0100, Steven Bosscher wrote:
>> Perhaps somewhere during the development of ree.c struct ext_cand was
>> GGC-allocated, in which case TODO_ggc_collect would make sense, to
>> collect the ext_cands (there can
On Fri, Dec 07, 2012 at 11:25:38AM +0100, Steven Bosscher wrote:
> Perhaps somewhere during the development of ree.c struct ext_cand was
> GGC-allocated, in which case TODO_ggc_collect would make sense, to
> collect the ext_cands (there can be many of them). But since ext_cands
> are not GGC-alloca
On Fri, Dec 7, 2012 at 10:57 AM, Jakub Jelinek wrote:
> I'd say removing the GTY(()) on a struct that is never GC allocated
> nor interesting to PCH is obvious, the removal of TODO_ggc_collect is not
> so. Right now it is set by passes that expect to potentially
> create enough GC garbage that a c
On Fri, Dec 07, 2012 at 10:51:39AM +0100, Steven Bosscher wrote:
> On Fri, Dec 7, 2012 at 10:42 AM, Steven Bosscher wrote:
> > In the mean time -- comments on my patch?
>
> Oh, never mind, I forgot I was going to commit this as obvious :-)
I'd say removing the GTY(()) on a struct that is never GC
On Fri, Dec 7, 2012 at 10:42 AM, Steven Bosscher wrote:
> In the mean time -- comments on my patch?
Oh, never mind, I forgot I was going to commit this as obvious :-)
Ciao!
Steven
On Fri, Dec 7, 2012 at 10:08 AM, Richard Biener
wrote:
> On Fri, Dec 7, 2012 at 1:05 AM, Steven Bosscher wrote:
>> Hello,
>>
>> ree.c's data structures are not GC-allocated, so its GTY markers and
>> its TODO_ggc_collect are unnecessary.
>>
>> Will commit as obvious after the usual testing on my
On Fri, Dec 7, 2012 at 1:05 AM, Steven Bosscher wrote:
> Hello,
>
> ree.c's data structures are not GC-allocated, so its GTY markers and
> its TODO_ggc_collect are unnecessary.
>
> Will commit as obvious after the usual testing on my favourite platforms :-)
IMHO TODO_ggc_collect should go and we
Hello,
ree.c's data structures are not GC-allocated, so its GTY markers and
its TODO_ggc_collect are unnecessary.
Will commit as obvious after the usual testing on my favourite platforms :-)
* ree.c (struct ext_cand): Remove GTY markers.
(pass_ree): Remove TODO_ggc_collect.
Inde
