On Oct 23, 2012, at 2:02 PM, Jason Merrill wrote:
> OK.
>
> Jason
Thanks. Committed.
paul
OK.
Jason
On Oct 5, 2012, at 6:05 PM, Cary Coutant wrote:
>> There certainly is a fair amount of code in dwarf2read.c in gdb to handle
>> DW_AT_declaration and do things differently for declarations.
>>
>> Should I rework this patch to use that mechanism instead? If so, how? If
>> the class is marked
On Oct 5, 2012, at 6:05 PM, Cary Coutant wrote:
>> There certainly is a fair amount of code in dwarf2read.c in gdb to handle
>> DW_AT_declaration and do things differently for declarations.
>>
>> Should I rework this patch to use that mechanism instead? If so, how? If
>> the class is marked
> There certainly is a fair amount of code in dwarf2read.c in gdb to handle
> DW_AT_declaration and do things differently for declarations.
>
> Should I rework this patch to use that mechanism instead? If so, how? If
> the class is marked only by prune_unused_types_mark visiting it as a parent,
On Oct 5, 2012, at 2:43 PM, Cary Coutant wrote:
>>> It seems to me that there are cases where we just want to emit the
>>> class for the context info (like a namespace, which doesn't have to be
>>> complete everywhere). Is there a way to tell the debugger that this
>>> class declaration is incomp
On Oct 5, 2012, at 2:43 PM, Cary Coutant wrote:
>>> It seems to me that there are cases where we just want to emit the
>>> class for the context info (like a namespace, which doesn't have to be
>>> complete everywhere). Is there a way to tell the debugger that this
>>> class declaration is incomp
>> It seems to me that there are cases where we just want to emit the
>> class for the context info (like a namespace, which doesn't have to be
>> complete everywhere). Is there a way to tell the debugger that this
>> class declaration is incomplete and that it should look elsewhere for
>> a full d
On 10/04/2012 08:26 PM, Cary Coutant wrote:
It seems to me that there are cases where we just want to emit the
class for the context info (like a namespace, which doesn't have to be
complete everywhere). Is there a way to tell the debugger that this
class declaration is incomplete and that it sho
> So given the comments, is this patch now ok to commit?
Yes, this is OK. Thanks for doing the extra testing! (I also ran a
quick test with -fdebug-types-section, just to make sure.)
-cary
On Oct 5, 2012, at 11:34 AM,
wrote:
>
> On Oct 5, 2012, at 4:16 AM, Jakub Jelinek wrote:
>
>> On Thu, Oct 04, 2012 at 05:26:11PM -0700, Cary Coutant wrote:
Index: gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C
===
>>>
On Oct 5, 2012, at 4:16 AM, Jakub Jelinek wrote:
> On Thu, Oct 04, 2012 at 05:26:11PM -0700, Cary Coutant wrote:
>>> Index: gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C
>>> ===
>>> --- gcc/testsuite/g++.dg/debug/dwarf2/localclass1
On Thu, Oct 04, 2012 at 05:26:11PM -0700, Cary Coutant wrote:
> > Index: gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C
> > ===
> > --- gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C (revision 192048)
> > +++ gcc/testsuite/g++.dg
On Oct 4, 2012, at 8:26 PM, Cary Coutant wrote:
>> Index: gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C
>> ===
>> --- gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C (revision 192048)
>> +++ gcc/testsuite/g++.dg/debug/dwarf2/lo
On Oct 4, 2012, at 8:26 PM, Cary Coutant wrote:
>> Index: gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C
>> ===
>> --- gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C (revision 192048)
>> +++ gcc/testsuite/g++.dg/debug/dwarf2/lo
> Index: gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C
> ===
> --- gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C (revision 192048)
> +++ gcc/testsuite/g++.dg/debug/dwarf2/localclass1.C (working copy)
> @@ -59,11 +59,11 @@
>
Updated patch: there were two existing testcases that needed to be adjusted
because of this fix.
Ran check RUNTESTFLAGS=dwarf2.exp, no regressions.
paul
ChangeLog:
2012-10-04 Paul Koning
* dwarf2out.c (prune_unused_types_mark): Mark all of parent's
children if paren
On Oct 4, 2012, at 12:09 PM,
wrote:
> Ping ^ 2...
>
> --
>
> If the only reference in a source file is to a static method of a class, then
> GCC would output debug information for the class name but not any of its
> members or base classes. The attached patch fixes this by having
> "
On Oct 4, 2012, at 2:58 PM, Jakub Jelinek wrote:
> On Thu, Oct 04, 2012 at 06:32:20PM +, paul_kon...@dell.com wrote:
>> --- testsuite/g++.dg/debug/dwarf2/pr54508.C (revision 0)
>> +++ testsuite/g++.dg/debug/dwarf2/pr54508.C (revision 0)
>> @@ -0,0 +1,67 @@
>> +// PR debug/54508
>> +// { dg-
On Thu, Oct 04, 2012 at 06:32:20PM +, paul_kon...@dell.com wrote:
> --- testsuite/g++.dg/debug/dwarf2/pr54508.C (revision 0)
> +++ testsuite/g++.dg/debug/dwarf2/pr54508.C (revision 0)
> @@ -0,0 +1,67 @@
> +// PR debug/54508
> +// { dg-do compile }
> +// { dg-options "-g2 -dA" }
Better than
On Oct 4, 2012, at 1:38 PM, Cary Coutant wrote:
>> /* We also have to mark its parents as used.
>> -(But we don't want to mark our parents' kids due to this.) */
>> +(But we don't want to mark our parent's kids due to this,
>> +unless it is a class.) */
>> if (
> /* We also have to mark its parents as used.
> -(But we don't want to mark our parents' kids due to this.) */
> +(But we don't want to mark our parent's kids due to this,
> +unless it is a class.) */
> if (die->die_parent)
> - prune_unused_types_mark (d
Ping ^ 2...
--
If the only reference in a source file is to a static method of a class, then
GCC would output debug information for the class name but not any of its
members or base classes. The attached patch fixes this by having
"prune_unused_types_mark" mark all of the parent's childre
Ping...
paul
Begin forwarded message:
> From:
> Date: September 20, 2012 4:55:05 PM EDT
> To:
> Subject: Re: [patch] pr/54508: fix incomplete debug information for class
>
> Attached below is an update to the testcase file, to fix the scan-assembler
> reg
Attached below is an update to the testcase file, to fix the scan-assembler
regexp comment character matching. This uses the same regexp element that H-P
Nilsson used in the fix to nested-3.C two days ago.
By the way, I ran check-g++ for dwarf2.exp on this change, no regressions.
Ok to commit?
If the only reference in a source file is to a static method of a class, then
GCC would output debug information for the class name but not any of its
members or base classes. The attached patch fixes this by having
"prune_unused_types_mark" mark all of the parent's children if the parent DIE
26 matches
Mail list logo
