Re: PING Fwd: [patch] implement generic debug() for vectors and hash sets

2018-02-12 Thread Jason Merrill
On Mon, Nov 20, 2017 at 6:47 AM, Aldy Hernandez wrote: > Minor oversight... > > debug_vec_tree() no longer exist. I forgot to remove the prototype. > > Also, gdbinit.in has a macro that uses it, but this is no longer > necessary as we can print tree vectors generically with "print > debug(xxx)".

Re: [patch] implement generic debug() for vectors and hash sets

2017-11-27 Thread Jeff Law
On 11/27/2017 08:03 AM, Aldy Hernandez wrote: > > > On 11/23/2017 02:12 PM, Gerald Pfeifer wrote: >> On Tue, 21 Nov 2017, Gerald Pfeifer wrote: >>> /scratch/tmp/gerald/GCC-HEAD/gcc/print-rtl.c:982:1: error: explicit >>> instantiation cannot have a storage class >>> DEFINE_DEBUG_VEC (rtx_def *) >>

Re: [patch] implement generic debug() for vectors and hash sets

2017-11-27 Thread Aldy Hernandez
On 11/23/2017 02:12 PM, Gerald Pfeifer wrote: On Tue, 21 Nov 2017, Gerald Pfeifer wrote: /scratch/tmp/gerald/GCC-HEAD/gcc/print-rtl.c:982:1: error: explicit instantiation cannot have a storage class DEFINE_DEBUG_VEC (rtx_def *) ^ /scratch/tmp/gerald/GCC-HEAD/gcc/vec.h:456:24: note: expanded f

Re: [patch] implement generic debug() for vectors and hash sets

2017-11-23 Thread Gerald Pfeifer
On Tue, 21 Nov 2017, Gerald Pfeifer wrote: > /scratch/tmp/gerald/GCC-HEAD/gcc/print-rtl.c:982:1: error: explicit > instantiation cannot have a storage class > DEFINE_DEBUG_VEC (rtx_def *) > ^ > /scratch/tmp/gerald/GCC-HEAD/gcc/vec.h:456:24: note: expanded from macro > 'DEFINE_DEBUG_VEC' > templ

Re: [patch] implement generic debug() for vectors and hash sets

2017-11-21 Thread Gerald Pfeifer
On Tue, 21 Nov 2017, Aldy Hernandez wrote: > I have no idea how to bootstrap with clang :). Perhaps someone can > throw a hint. It just works. Usually. :-) I run two testers, one nightly, one weekly, on a FreeBSD.org cluster, one with clang 3.4 the other with clang 4.0 right now, and while bot

Re: [patch] implement generic debug() for vectors and hash sets

2017-11-21 Thread Aldy Hernandez
On 11/21/2017 05:59 AM, Gerald Pfeifer wrote: On Mon, 20 Nov 2017, Aldy Hernandez wrote: Minor oversight... Actually, there appears to be another issue related to this when bootstrapping with clang 3.4.1 (FreeBSD 10.4): I have no idea how to bootstrap with clang :). Perhaps someone can t

Re: [patch] implement generic debug() for vectors and hash sets

2017-11-21 Thread Gerald Pfeifer
On Mon, 20 Nov 2017, Aldy Hernandez wrote: > Minor oversight... Actually, there appears to be another issue related to this when bootstrapping with clang 3.4.1 (FreeBSD 10.4): /scratch/tmp/gerald/GCC-HEAD/gcc/print-rtl.c:982:1: error: explicit instantiation cannot have a storage class DEFINE_DE

Re: PING Fwd: [patch] implement generic debug() for vectors and hash sets

2017-11-20 Thread Aldy Hernandez
5 PM, Jeff Law wrote: > On 10/23/2017 03:44 AM, Aldy Hernandez wrote: >> >> >> >> Forwarded Message ---- >> Subject: [patch] implement generic debug() for vectors and hash sets >> Date: Mon, 16 Oct 2017 09:52:51 -0400 >> From: Aldy Hernandez

Re: PING Fwd: [patch] implement generic debug() for vectors and hash sets

2017-11-19 Thread Jeff Law
On 10/23/2017 03:44 AM, Aldy Hernandez wrote: > > > >  Forwarded Message  > Subject: [patch] implement generic debug() for vectors and hash sets > Date: Mon, 16 Oct 2017 09:52:51 -0400 > From: Aldy Hernandez  > To: gcc-patches  > > We have a gener

Fwd: [patch] implement generic debug() for vectors and hash sets

2017-11-13 Thread Aldy Hernandez
PING*3 -- Forwarded message -- From: Aldy Hernandez Date: Mon, Oct 16, 2017 at 9:52 AM Subject: [patch] implement generic debug() for vectors and hash sets To: gcc-patches We have a generic mechanism for dumping types from the debugger with: (gdb) call debug(some_type

PING*2 Fwd: [patch] implement generic debug() for vectors and hash sets

2017-11-01 Thread Aldy Hernandez
-- Forwarded message -- From: Aldy Hernandez Date: Mon, Oct 16, 2017 at 9:52 AM Subject: [patch] implement generic debug() for vectors and hash sets To: gcc-patches We have a generic mechanism for dumping types from the debugger with: (gdb) call debug(some_type) However, even

PING Fwd: [patch] implement generic debug() for vectors and hash sets

2017-10-23 Thread Aldy Hernandez
Forwarded Message Subject: [patch] implement generic debug() for vectors and hash sets Date: Mon, 16 Oct 2017 09:52:51 -0400 From: Aldy Hernandez To: gcc-patches We have a generic mechanism for dumping types from the debugger with: (gdb) call debug(some_type) However

Re: [patch] implement generic debug() for vectors and hash sets

2017-10-16 Thread Aldy Hernandez
One more thing. I see we have a "pvt" macro in gdbinit.in: define pvt set debug_vec_tree ($) end I propose we either remove this altogether, since we have a generic debug() way of dumping things, or implement it with "set debug($)" if somebody's finger memory will be adversely affected. (I'm lo

[patch] implement generic debug() for vectors and hash sets

2017-10-16 Thread Aldy Hernandez
We have a generic mechanism for dumping types from the debugger with: (gdb) call debug(some_type) However, even though most types are implemented, we have no canonical way of dumping vectors or hash sets. The attached patch fixes this oversight. With it you can call debug(vec<>) and debug(hash_