Re: [patch] gcc fstack-protector-explicit

2015-01-22 Thread Jakub Jelinek
On Thu, Jan 22, 2015 at 09:35:45AM -0700, Jeff Law wrote: > >Though wonder if for the TARGET_LIBC_PROVIDES_SSP case LINK_SSP_SPEC > >shouldn't be > >#define LINK_SSP_SPEC > >"{fstack-protector|fstack-protector-strong|fstack-protector-explicit|fstack-protector-all:}" > >and > >gcc/config/freebsd.h:

Re: [patch] gcc fstack-protector-explicit

2015-01-22 Thread Jeff Law
On 01/22/15 05:37, Jakub Jelinek wrote: On Wed, Jan 21, 2015 at 10:07:14AM +0100, Rainer Orth wrote: Ok for mainline once that has been done? Thanks. Rainer 2015-01-20 Rainer Orth * gcc.c (LINK_SSP_SPEC): Handle -fstack-protector-explicit. Ok. Though wonder if for the TA

Re: [patch] gcc fstack-protector-explicit

2015-01-22 Thread Jakub Jelinek
On Wed, Jan 21, 2015 at 10:07:14AM +0100, Rainer Orth wrote: > Ok for mainline once that has been done? > > Thanks. > Rainer > > > 2015-01-20 Rainer Orth > > * gcc.c (LINK_SSP_SPEC): Handle -fstack-protector-explicit. Ok. Though wonder if for the TARGET_LIBC_PROVIDES_SSP case LI

Re: [patch] gcc fstack-protector-explicit

2015-01-21 Thread Rainer Orth
Jeff Law writes: > On 07/01/14 15:34, Daniel Gutson wrote: >> On Tue, Jul 1, 2014 at 2:25 PM, Jeff Law wrote: >>> On 03/19/14 08:06, Marcos Díaz wrote: Well, finally I have the assignment, could you please review this patch? >>> >>> Thanks. >>> >>> My first thought was that if we've ma

Re: [patch] gcc fstack-protector-explicit

2015-01-14 Thread Jeff Law
On 07/01/14 15:34, Daniel Gutson wrote: On Tue, Jul 1, 2014 at 2:25 PM, Jeff Law wrote: On 03/19/14 08:06, Marcos Díaz wrote: Well, finally I have the assignment, could you please review this patch? Thanks. My first thought was that if we've marked the function with an explicit static prot

Re: [patch] gcc fstack-protector-explicit

2014-09-17 Thread Marcos Díaz
On Wed, Jul 2, 2014 at 2:58 PM, Marcos Díaz wrote: > On Tue, Jul 1, 2014 at 6:34 PM, Daniel Gutson > wrote: >> On Tue, Jul 1, 2014 at 2:25 PM, Jeff Law wrote: >>> On 03/19/14 08:06, Marcos Díaz wrote: Well, finally I have the assignment, could you please review this patch? >>> >>> Than

Re: [patch] gcc fstack-protector-explicit

2014-07-02 Thread Marcos Díaz
On Tue, Jul 1, 2014 at 6:34 PM, Daniel Gutson wrote: > On Tue, Jul 1, 2014 at 2:25 PM, Jeff Law wrote: >> On 03/19/14 08:06, Marcos Díaz wrote: >>> >>> Well, finally I have the assignment, could you please review this patch? >> >> Thanks. >> >> My first thought was that if we've marked the functi

Re: [patch] gcc fstack-protector-explicit

2014-07-01 Thread Daniel Gutson
On Tue, Jul 1, 2014 at 2:25 PM, Jeff Law wrote: > On 03/19/14 08:06, Marcos Díaz wrote: >> >> Well, finally I have the assignment, could you please review this patch? > > Thanks. > > My first thought was that if we've marked the function with an explicit > static protector attribute, then it ought

Re: [patch] gcc fstack-protector-explicit

2014-07-01 Thread Jeff Law
On 03/19/14 08:06, Marcos Díaz wrote: Well, finally I have the assignment, could you please review this patch? Thanks. My first thought was that if we've marked the function with an explicit static protector attribute, then it ought to be protected regardless of any flags. Is there some reas

Re: [patch] gcc fstack-protector-explicit

2014-05-12 Thread Marcos Díaz
On Wed, Mar 19, 2014 at 11:09 AM, Jeff Law wrote: > On 03/19/14 08:06, Marcos Díaz wrote: >> >> Well, finally I have the assignment, could you please review this patch? > > Thanks. I'll take a look once we open up stage1 development again (should > be soon as 4.9 is getting close to being ready).

Re: [patch] gcc fstack-protector-explicit

2014-03-19 Thread Jeff Law
On 03/19/14 08:06, Marcos Díaz wrote: Well, finally I have the assignment, could you please review this patch? Thanks. I'll take a look once we open up stage1 development again (should be soon as 4.9 is getting close to being ready). jeff

Re: [patch] gcc fstack-protector-explicit

2014-03-19 Thread Marcos Díaz
Well, finally I have the assignment, could you please review this patch? On Wed, Nov 20, 2013 at 4:13 PM, Jeff Law wrote: > On 11/19/13 07:04, Marcos Díaz wrote: >> >> My employer is working on the signature of the papers. Could someone >> please do the review meanwhile? > > I'd prefer to wait un

Re: [patch] gcc fstack-protector-explicit

2013-11-20 Thread Jeff Law
On 11/19/13 07:04, Marcos Díaz wrote: My employer is working on the signature of the papers. Could someone please do the review meanwhile? I'd prefer to wait until the assignment process is complete. If something were to happen and we can't use your code the review time would have been wasted

Re: [patch] gcc fstack-protector-explicit

2013-11-19 Thread Marcos Díaz
My employer is working on the signature of the papers. Could someone please do the review meanwhile? On Tue, Nov 19, 2013 at 3:00 AM, Jeff Law wrote: > On 11/18/13 13:05, Marcos Díaz wrote: >> >> Hi, >> the attached patch adds a new attribute and option flag to control >> when to do stack pro

Re: [patch] gcc fstack-protector-explicit

2013-11-18 Thread Jeff Law
On 11/18/13 13:05, Marcos Díaz wrote: Hi, the attached patch adds a new attribute and option flag to control when to do stack protection. The new attribute (stack_protect) affects the behavior of gcc by forcing the stack protection of the function marked with the attribute if any of the opti

[patch] gcc fstack-protector-explicit

2013-11-18 Thread Marcos Díaz
Hi, the attached patch adds a new attribute and option flag to control when to do stack protection. The new attribute (stack_protect) affects the behavior of gcc by forcing the stack protection of the function marked with the attribute if any of the options -fstack-protector, -fstack-protector-