Re: [patch] cleanup *finish_omp_clauses

2016-06-10 Thread Thomas Schwinge
Hi! On Tue, 3 May 2016 08:35:29 +0200, Marek Polacek wrote: > This patch introduced > > /home/marek/src/gcc/gcc/c-family/c-common.h:1270:58: warning: comma at end of > enumerator list [-Wpedantic] >C_ORT_OMP_DECLARE_SIMD = C_ORT_OMP | C_ORT_DECLARE_SIMD, >

Re: [patch] cleanup *finish_omp_clauses

2016-05-02 Thread Marek Polacek
This patch introduced /home/marek/src/gcc/gcc/c-family/c-common.h:1270:58: warning: comma at end of enumerator list [-Wpedantic] C_ORT_OMP_DECLARE_SIMD = C_ORT_OMP | C_ORT_DECLARE_SIMD, ^ I'm fixing that with 2016-05-03 Marek Polacek

Re: [patch] cleanup *finish_omp_clauses

2016-05-01 Thread Jakub Jelinek
On Sun, May 01, 2016 at 08:11:24PM -0700, Cesar Philippidis wrote: > On 04/29/2016 12:39 AM, Jakub Jelinek wrote: > > >> -extern tree c_finish_omp_clauses (tree, bool, bool = false, bool = false); > >> +extern tree c_finish_omp_clauses (tree, unsigned int); > > > > I think it would be better to a

Re: [patch] cleanup *finish_omp_clauses

2016-05-01 Thread Cesar Philippidis
On 04/29/2016 12:39 AM, Jakub Jelinek wrote: >> -extern tree c_finish_omp_clauses (tree, bool, bool = false, bool = false); >> +extern tree c_finish_omp_clauses (tree, unsigned int); > > I think it would be better to assign an enum value also for the > C_ORT_OMP | C_ORT_DECLARE_SIMD (C_ORT_OMP_DE

Re: [patch] cleanup *finish_omp_clauses

2016-04-29 Thread Jakub Jelinek
On Thu, Apr 28, 2016 at 10:42:49AM -0700, Cesar Philippidis wrote: > > That said, the above names are just weird, it is non-obvious > > what they mean at all. What is C_ORT_NONE for? We surely don't > > have any clauses that aren't OpenMP, nor Cilk+, nor OpenACC > > (ok, maybe the simd attribute,

Re: [patch] cleanup *finish_omp_clauses

2016-04-28 Thread Cesar Philippidis
On 04/28/2016 01:56 AM, Jakub Jelinek wrote: > On Wed, Apr 27, 2016 at 07:37:17PM -0700, Cesar Philippidis wrote: >> This patch replaces all of the bool argument to c_finish_omp_clauses and >> finish_omp_clauses in the c and c++ front ends, respectively. Right now >> there are three bool arguments,

Re: [patch] cleanup *finish_omp_clauses

2016-04-28 Thread Jakub Jelinek
On Wed, Apr 27, 2016 at 07:37:17PM -0700, Cesar Philippidis wrote: > This patch replaces all of the bool argument to c_finish_omp_clauses and > finish_omp_clauses in the c and c++ front ends, respectively. Right now > there are three bool arguments, one for is_omp/allow_fields, > declare_simd and i

[patch] cleanup *finish_omp_clauses

2016-04-27 Thread Cesar Philippidis
This patch replaces all of the bool argument to c_finish_omp_clauses and finish_omp_clauses in the c and c++ front ends, respectively. Right now there are three bool arguments, one for is_omp/allow_fields, declare_simd and is_cilk, the latter two have default values set. OpenACC will require some s