Re: [patch] Simplify non-inline function definitions for std::unordered_xxx containers

2014-12-05 Thread Jonathan Wakely
On 03/12/14 12:00 +, Jonathan Wakely wrote: While working on PR57272 for unordered containers I was getting a headache reading all the return types with nested-name-qualifiers split over three or four lines. More of the same. Tested powerpc64-linux, committed to trunk. commit f99108f25854

Re: [patch] Simplify non-inline function definitions for std::unordered_xxx containers

2014-12-04 Thread Jonathan Wakely
On 04/12/14 14:11 +, Jonathan Wakely wrote: Although this touches almost every line of the hashtable.h and hastable_policy.h files, it's mostly mechanical. The main purpose is to replace every use of X* with a typedef like X_pointer, which comes from the allocator. In the common case it's jus

Re: [patch] Simplify non-inline function definitions for std::unordered_xxx containers

2014-12-04 Thread Jonathan Wakely
On 04/12/14 11:39 +, Jonathan Wakely wrote: On 03/12/14 23:32 +0100, François Dumont wrote: On 03/12/2014 16:59, Jonathan Wakely wrote: François (or anyone else), do you see any problem with this change? It makes the code shorter and I think is much easier to read, it also reduces the memo

[patch] Simplify non-inline function definitions for std::unordered_xxx containers

2014-12-03 Thread Jonathan Wakely
While working on PR57272 for unordered containers I was getting a headache reading all the return types with nested-name-qualifiers split over three or four lines. This patch replaces them with trailing return types, so the names used in the return type are in scope and don't need to be qualified