Re: [patch] Rewrite check_global_declarations() generically

2015-04-30 Thread Richard Biener
On Wed, Apr 29, 2015 at 3:01 AM, Aldy Hernandez wrote: > [This is actually for the debug-early branch, but I figured I'd avoid the > [debug-early] subject line to alert others of the upcoming change. Actually, > I should've adapted this and submitted it to mainline, but considering I > should be s

Re: [patch] Rewrite check_global_declarations() generically

2015-04-29 Thread Aldy Hernandez
On 04/29/2015 12:33 PM, Jason Merrill wrote: On 04/28/2015 09:01 PM, Aldy Hernandez wrote: The approach looks good to me. - analyze_functions (); + analyze_functions (true); In the C++ front end at least we comment anonymous boolean arguments, i.e. analyze_functions (/*first_time*/true)

Re: [patch] Rewrite check_global_declarations() generically

2015-04-29 Thread Jason Merrill
On 04/28/2015 09:01 PM, Aldy Hernandez wrote: The approach looks good to me. - analyze_functions (); + analyze_functions (true); In the C++ front end at least we comment anonymous boolean arguments, i.e. analyze_functions (/*first_time*/true); Let's do that here, too. Similarly for the

[patch] Rewrite check_global_declarations() generically

2015-04-28 Thread Aldy Hernandez
[This is actually for the debug-early branch, but I figured I'd avoid the [debug-early] subject line to alert others of the upcoming change. Actually, I should've adapted this and submitted it to mainline, but considering I should be submitting the debug-early work "Real Soon Now" (tm), I don't