Re: [patch] PR tree-optimization/55350: invalid pointer operand to PLUS_EXPR

2012-11-20 Thread Eric Botcazou
> Actually the ChangeLog is correct, what was incorrect was the svn commit > message. Is there a way to change the commit message retroactively? Probably, but I wouldn't bother about that. -- Eric Botcazou

Re: [patch] PR tree-optimization/55350: invalid pointer operand to PLUS_EXPR

2012-11-20 Thread Aldy Hernandez
On 11/20/12 16:23, Eric Botcazou wrote: The problem here is that the SLSR pass is promoting a POINTER_PLUS_EXPR to a PLUS_EXPR. Since pointer arithmetic is invalid in {PLUS,MINUS}_EXPR's, the gimple verifier chokes on the invalid statement. Fixed by maintaining the POINTER_PLUS_EXPR when approp

Re: [patch] PR tree-optimization/55350: invalid pointer operand to PLUS_EXPR

2012-11-20 Thread Eric Botcazou
> The problem here is that the SLSR pass is promoting a POINTER_PLUS_EXPR > to a PLUS_EXPR. Since pointer arithmetic is invalid in > {PLUS,MINUS}_EXPR's, the gimple verifier chokes on the invalid statement. > > Fixed by maintaining the POINTER_PLUS_EXPR when appropriate. > > OK for trunk? The C

Re: [patch] PR tree-optimization/55350: invalid pointer operand to PLUS_EXPR

2012-11-20 Thread Jakub Jelinek
On Tue, Nov 20, 2012 at 11:46:06AM -0600, Aldy Hernandez wrote: > The problem here is that the SLSR pass is promoting a > POINTER_PLUS_EXPR to a PLUS_EXPR. Since pointer arithmetic is > invalid in {PLUS,MINUS}_EXPR's, the gimple verifier chokes on the > invalid statement. > > Fixed by maintaining

[patch] PR tree-optimization/55350: invalid pointer operand to PLUS_EXPR

2012-11-20 Thread Aldy Hernandez
The problem here is that the SLSR pass is promoting a POINTER_PLUS_EXPR to a PLUS_EXPR. Since pointer arithmetic is invalid in {PLUS,MINUS}_EXPR's, the gimple verifier chokes on the invalid statement. Fixed by maintaining the POINTER_PLUS_EXPR when appropriate. OK for trunk? commit ae7b615a11