Re: [patch] PR debug/58123: Set correct location for TRY blocks

2015-02-23 Thread Aldy Hernandez
On 02/23/2015 10:37 AM, Jason Merrill wrote: On 02/19/2015 12:31 PM, Aldy Hernandez wrote: As explained in the PR, I would ideally like to get rid of the kludge where we set the location of location-less FINALLY statements to be that of the TRY statement, but that may be by design, and/or beyond

Re: [patch] PR debug/58123: Set correct location for TRY blocks

2015-02-23 Thread Jason Merrill
On 02/19/2015 12:31 PM, Aldy Hernandez wrote: As explained in the PR, I would ideally like to get rid of the kludge where we set the location of location-less FINALLY statements to be that of the TRY statement, but that may be by design, and/or beyond the scope of this fix. This reminds me of t

Re: [patch] PR debug/58123: Set correct location for TRY blocks

2015-02-20 Thread Jeff Law
On 02/19/15 10:31, Aldy Hernandez wrote: [Ughh...I'm apparently incapable of CCing gcc-patches on the first try. My apologies again.] Please see the long explanation in the PR: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58123 But the short explanation for this patch is that, at the very le

[patch] PR debug/58123: Set correct location for TRY blocks

2015-02-19 Thread Aldy Hernandez
[Ughh...I'm apparently incapable of CCing gcc-patches on the first try. My apologies again.] Please see the long explanation in the PR: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58123 But the short explanation for this patch is that, at the very least, we should fix the location of the GIM