Re: [PATCH] Minor tweaks to code computing modular multiplicative inverse

2024-04-29 Thread Eric Botcazou
> OK. Consider waiting to commit though as we want to make it easy to > cherry pick patches over to the release branch if needed. Sure. There are a couple more changes on top of it, but all can wait a bit. -- Eric Botcazou

Re: [PATCH] Minor tweaks to code computing modular multiplicative inverse

2024-04-29 Thread Jeff Law
On 4/29/24 1:14 AM, Eric Botcazou wrote: Hi, this removes the last parameter of choose_multiplier, which is unused, adds another assertion and more details to the description and various comments. Likewise to the closely related invert_mod2n, except for the last parameter. Tested on x86-64/L

[PATCH] Minor tweaks to code computing modular multiplicative inverse

2024-04-29 Thread Eric Botcazou
Hi, this removes the last parameter of choose_multiplier, which is unused, adds another assertion and more details to the description and various comments. Likewise to the closely related invert_mod2n, except for the last parameter. Tested on x86-64/Linux, OK for the mainline? 2024-04-29 Eric

Re: [patch] Minor tweaks

2012-03-19 Thread Eric Botcazou
> Ok. I think volatilep should be always set as well. Thanks. No strong opinion, but at least one caller (fold_truthop through decode_field_reference) calls the function 4 times in a row and only checks volatilep at the end to disable the transformation. -- Eric Botcazou

Re: [patch] Minor tweaks

2012-03-19 Thread Richard Guenther
On Mon, Mar 19, 2012 at 1:21 PM, Eric Botcazou wrote: > Hi, > > around line 380, we have in tree.def: > > /* References to storage.  */ > > /* The ordering of the following codes is optimized for the classification >   in handled_component_p.  Keep them in a consecutive group.  */ > > The hitch is

[patch] Minor tweaks

2012-03-19 Thread Eric Botcazou
Hi, around line 380, we have in tree.def: /* References to storage. */ /* The ordering of the following codes is optimized for the classification in handled_component_p. Keep them in a consecutive group. */ The hitch is that VIEW_CONVERT_EXPR is far apart from the others, so the patch pu