Re: [patch] Fix parsing bug in validate_patches.py

2013-06-06 Thread Diego Novillo
On 2013-06-05 14:34 , Brooks Moses wrote: I've tested the adjusted line-stripping parts of the refactored code by adding and removing spaces in lines in my xfails file and confirming that things are still correctly matched. Is this refactoring also OK to commit? Ah, thanks. That's a bette

Re: [patch] Fix parsing bug in validate_patches.py

2013-06-05 Thread Brooks Moses
On 06/04/2013 03:57 PM, Diego Novillo wrote: OK with this predicate factored into a predicate function (maybe SummaryLineHasAttributes?) Thanks! Once I dove into that, I ended up doing a bit more refactoring; it really makes sense to pull the whole line-splitting into a separate function alo

Re: [patch] Fix parsing bug in validate_patches.py

2013-06-04 Thread Diego Novillo
On 2013-05-31 14:47 , Brooks Moses wrote: Index: contrib/testsuite-management/validate_failures.py === --- contrib/testsuite-management/validate_failures.py(revision 199390) +++ contrib/testsuite-management/validate_failures.py

[patch] Fix parsing bug in validate_patches.py

2013-05-31 Thread Brooks Moses
The validate_failures.py script in contrib/testsuite-management expects the first "|" character in a test summary line to be a delineator allowing the line to be prefixed by attributes such as "flaky". This causes problems when a test line itself contains "|" in the message. We can get around