Re: [patch] Fix gnat.dg/pack19.adb on some platforms

2013-12-10 Thread Eric Botcazou
> :-) From a cleanup standpoint, I think the expansion code is ripe for > someone to spend (condsiderable) time killing dead code. I suspect > there's still significant gcc-1.91 (or even older) bits in there that > have been dead for at least a decade. The existing test was added for Ada a decad

Re: [patch] Fix gnat.dg/pack19.adb on some platforms

2013-12-09 Thread Jeff Law
On 12/09/13 16:17, Eric Botcazou wrote: Ugh. I don't care that much :-) If you want to handle it, go ahead. I would suggest a comment indicating why we've chosen to handle it. OK, I can do that. The only question left is would it be better to handle it in extract_bit_field to catch other ca

Re: [patch] Fix gnat.dg/pack19.adb on some platforms

2013-12-09 Thread Eric Botcazou
> Ugh. I don't care that much :-) If you want to handle it, go ahead. I > would suggest a comment indicating why we've chosen to handle it. OK, I can do that. > The only question left is would it be better to handle it in > extract_bit_field to catch other cases, or is that too late? I put it

Re: [patch] Fix gnat.dg/pack19.adb on some platforms

2013-12-09 Thread Jeff Law
On 12/09/13 15:41, Eric Botcazou wrote: But isn't the test bogus if it depends on the result of loading a zero sized bitfield? That's supported in Ada and the result is specified, it's the only allowed value of the type of the bitfield (the type has precision 0 and is biased if this value isn't

Re: [patch] Fix gnat.dg/pack19.adb on some platforms

2013-12-09 Thread Eric Botcazou
> But isn't the test bogus if it depends on the result of loading a zero > sized bitfield? That's supported in Ada and the result is specified, it's the only allowed value of the type of the bitfield (the type has precision 0 and is biased if this value isn't zero). So this boils down to an imp

Re: [patch] Fix gnat.dg/pack19.adb on some platforms

2013-12-09 Thread Jeff Law
On 12/09/13 04:16, Eric Botcazou wrote: Hi, the new test gnat.dg/pack19.adb doesn't pass on some platforms because of the target-dependent result of loads from bit-fields with size 0. Unlike the stores to these bit-fields which are handled in an uniform way in store_field: /* If we have not

[patch] Fix gnat.dg/pack19.adb on some platforms

2013-12-09 Thread Eric Botcazou
Hi, the new test gnat.dg/pack19.adb doesn't pass on some platforms because of the target-dependent result of loads from bit-fields with size 0. Unlike the stores to these bit-fields which are handled in an uniform way in store_field: /* If we have nothing to store, do nothing unless the expr