> But then why not expose this as extra field in ID instead of repeatedly
> calling gimple_location?
That's a matter of taste I guess.
> I don't have an issue with using input_location here until we fix the
> gimplifier...
OK, patch dropped.
--
Eric Botcazou
On June 28, 2018 12:28:15 PM GMT+02:00, Eric Botcazou
wrote:
>> More references to input_location aren't ideal. But I don't think
>> that's a strong enough reason to reject.
>
>This can be avoided relatively easily though, patch to that effect
>attached.
>
>Tested on x86-64/Linux, OK for the mai
> More references to input_location aren't ideal. But I don't think
> that's a strong enough reason to reject.
This can be avoided relatively easily though, patch to that effect attached.
Tested on x86-64/Linux, OK for the mainline?
* tree-inline.c (remap_gimple_stmt): Replace input_lo
On 06/27/2018 07:24 AM, Eric Botcazou wrote:
> Hi,
>
> the Ada compiler uses small functions defined in its runtime to implement
> various intrinsic operations and it always inlines them, even at -O0. But it
> doesn't want location information from the runtime files to appear in the
> debug in
Hi,
the Ada compiler uses small functions defined in its runtime to implement
various intrinsic operations and it always inlines them, even at -O0. But it
doesn't want location information from the runtime files to appear in the
debug info so it puts DECL_IGNORED_P on these functions. final.c
> Similar factoring of remap_location and copying/remapping edges goto_locus
> is a fix worth splitting out (and backporting eventually if a need arises).
Tentative patch attached, it passed basic testing. I'll do a full testing
cycle if this is the way to go.
* tree-inline.c (remap_l
On Wed, Jun 20, 2018 at 4:37 PM Eric Botcazou wrote:
>
> > There are fixes in this patch together with the new functionality -
> > can you split
> > those out? I'm thinking of the copy_edges_for_bb hunks as well as
> > the expand_call_inline ones.
>
> Like this?
OK.
Similar factoring of remap_l
> There are fixes in this patch together with the new functionality -
> can you split
> those out? I'm thinking of the copy_edges_for_bb hunks as well as
> the expand_call_inline ones.
Like this?
* tree-inline.c (copy_edges_for_bb): Minor tweak.
(maybe_move_debug_stmts_to_succe
On Wed, Jun 20, 2018 at 12:25 AM Eric Botcazou wrote:
>
> Hi,
>
> the Ada compiler uses small functions defined in its runtime to implement
> various intrinsic operations and it always inlines them, even at -O0. But it
> doesn't want location information from the runtime files to appear in the
>
Hi,
the Ada compiler uses small functions defined in its runtime to implement
various intrinsic operations and it always inlines them, even at -O0. But it
doesn't want location information from the runtime files to appear in the
debug info so it puts DECL_IGNORED_P on these functions. final.c
10 matches
Mail list logo
