Re: [patch] Cleanup tree-ssa-ter.c exports

2013-10-21 Thread Eric Botcazou
> what went wrong? I see it in my checkouts...? Just open the file in your preferred editor. :-) -- Eric Botcazou

Re: [patch] Cleanup tree-ssa-ter.c exports

2013-10-21 Thread Andrew MacLeod
On 10/20/2013 09:53 AM, Eric Botcazou wrote: Unfortunately, tree-ssa-ter.c also has 2 functions (find_replaceable_exprs() and dump_replaceable_exprs()) which are exported and utilized by tree-outof-ssa.c (the file is a part of the out-of-ssa module). So I moved the prototypes from tree-ssa-li

Re: [patch] Cleanup tree-ssa-ter.c exports

2013-10-20 Thread Eric Botcazou
> Unfortunately, tree-ssa-ter.c also has 2 functions > (find_replaceable_exprs() and dump_replaceable_exprs()) which are > exported and utilized by tree-outof-ssa.c (the file is a part of the > out-of-ssa module). So I moved the prototypes from tree-ssa-live.h into > a newly created tree-ssa-te

Re: [patch] Cleanup tree-ssa-ter.c exports

2013-09-24 Thread Andrew MacLeod
On 09/16/2013 10:42 AM, Andrew MacLeod wrote: On 09/16/2013 04:55 AM, Richard Biener wrote: On Fri, Sep 13, 2013 at 9:15 PM, Andrew MacLeod wrote: OK, a slightly different take.. I realized that I should be adding tree-outof-ssa.h to handle the 3 exports from tree-outof-ssa.c that are in ss

Re: [patch] Cleanup tree-ssa-ter.c exports

2013-09-16 Thread Andrew MacLeod
On 09/16/2013 04:55 AM, Richard Biener wrote: On Fri, Sep 13, 2013 at 9:15 PM, Andrew MacLeod wrote: OK, a slightly different take.. I realized that I should be adding tree-outof-ssa.h to handle the 3 exports from tree-outof-ssa.c that are in ssaexpand.h... In fact, by far the most sensible

Re: [patch] Cleanup tree-ssa-ter.c exports

2013-09-16 Thread Richard Biener
On Fri, Sep 13, 2013 at 9:15 PM, Andrew MacLeod wrote: > On 09/13/2013 11:11 AM, Andrew MacLeod wrote: >> >> On 09/13/2013 03:54 AM, Richard Biener wrote: >>> >>> On Thu, Sep 12, 2013 at 11:09 PM, Andrew MacLeod >>> wrote: There are 2 parts of tre-ssa-ter.c to address. is_repl

Re: [patch] Cleanup tree-ssa-ter.c exports

2013-09-13 Thread Andrew MacLeod
On 09/13/2013 11:11 AM, Andrew MacLeod wrote: On 09/13/2013 03:54 AM, Richard Biener wrote: On Thu, Sep 12, 2013 at 11:09 PM, Andrew MacLeod wrote: There are 2 parts of tre-ssa-ter.c to address. is_replaceable_p() is also used in expr.c, It has a flag to indicate where its being called from,

Re: [patch] Cleanup tree-ssa-ter.c exports

2013-09-13 Thread Andrew MacLeod
On 09/13/2013 03:54 AM, Richard Biener wrote: On Thu, Sep 12, 2013 at 11:09 PM, Andrew MacLeod wrote: There are 2 parts of tre-ssa-ter.c to address. is_replaceable_p() is also used in expr.c, It has a flag to indicate where its being called from, and we do different checks for each one. There

Re: [patch] Cleanup tree-ssa-ter.c exports

2013-09-13 Thread Richard Biener
h doesn't have a .c file, so leaving the stuff in the .c files where they are now is ok). So - I fear you have to re-do this patch (in a much simpler way). Thanks, Richard. More 20 of 66 [patch] Cleanup tree-ssa-ter.c exports Inbox x gcc x Andrew MacLeod 11:09 PM (10 hours ago)

[patch] Cleanup tree-ssa-ter.c exports

2013-09-12 Thread Andrew MacLeod
There are 2 parts of tre-ssa-ter.c to address. is_replaceable_p() is also used in expr.c, It has a flag to indicate where its being called from, and we do different checks for each one. There is a wrapper function stmt_is_replaceable_p() in tree-ssa-ter.c which hides the setting of the flag t