Re: [patch] Add a lexical block only when the callsite has source location info

2012-07-10 Thread Dehao Chen
On Tue, Jul 10, 2012 at 1:57 PM, Xinliang David Li wrote: > Is this related to the problem described in > http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01511.html ? This does not sounds related to me. This patch only fix the block info for phi_arg_t. The following patch is related to function spl

Re: [patch] Add a lexical block only when the callsite has source location info

2012-07-09 Thread Xinliang David Li
Is this related to the problem described in http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01511.html ? David On Mon, Jun 25, 2012 at 4:43 AM, Dehao Chen wrote: > During function inlining, a lexical block is added for each cloned > callee, and source info is attached to this block for addr2line to

Re: [patch] Add a lexical block only when the callsite has source location info

2012-06-26 Thread Richard Guenther
On Tue, Jun 26, 2012 at 9:03 AM, Dehao Chen wrote: > Hi, Richard, > > You are right, setting UNKNOWN_LOCATION will not affect addr2line > result. Here is the updated patch: > > Passed bootstrap and gcc regression tests. > > Is it ok for trunk? Yes. Thanks, Richard. > Thanks, > Dehao > > Index:

Re: [patch] Add a lexical block only when the callsite has source location info

2012-06-26 Thread Dehao Chen
Hi, Richard, You are right, setting UNKNOWN_LOCATION will not affect addr2line result. Here is the updated patch: Passed bootstrap and gcc regression tests. Is it ok for trunk? Thanks, Dehao Index: tree-inline.c === --- tree-inlin

Re: [patch] Add a lexical block only when the callsite has source location info

2012-06-25 Thread Richard Guenther
On Mon, Jun 25, 2012 at 3:48 PM, Dehao Chen wrote: > Hi, Richard, > > Thanks for the prompt response. > > On Mon, Jun 25, 2012 at 8:02 PM, Richard Guenther > wrote: >> On Mon, Jun 25, 2012 at 1:43 PM, Dehao Chen wrote: >>> During function inlining, a lexical block is added for each cloned >>> ca

Re: [patch] Add a lexical block only when the callsite has source location info

2012-06-25 Thread Dehao Chen
Hi, Richard, Thanks for the prompt response. On Mon, Jun 25, 2012 at 8:02 PM, Richard Guenther wrote: > On Mon, Jun 25, 2012 at 1:43 PM, Dehao Chen wrote: >> During function inlining, a lexical block is added for each cloned >> callee, and source info is attached to this block for addr2line to

Re: [patch] Add a lexical block only when the callsite has source location info

2012-06-25 Thread Richard Guenther
On Mon, Jun 25, 2012 at 1:43 PM, Dehao Chen wrote: > During function inlining, a lexical block is added for each cloned > callee, and source info is attached to this block for addr2line to > derive the inline stack. Well - the bug is then clearly /* Set input_location here so we get the right

[patch] Add a lexical block only when the callsite has source location info

2012-06-25 Thread Dehao Chen
During function inlining, a lexical block is added for each cloned callee, and source info is attached to this block for addr2line to derive the inline stack. However, some callsites do not have source information attached to it. Adding a lexical block would be misleading in this case. E.g. If a fu