Re: [patch][gomp4] openacc loops

2014-06-16 Thread Ilmir Usmanov
Hi Cesar! Sorry for long delay, I was busy at the institute. On 05.06.2014 07:58, Cesar Philippidis wrote: I didn't see a whole lot different from your gfc_trans_oacc_loop and the existing gfc_trans_omp_do, so I augmented the latter to handle the openacc loop clause. It looks like the only imp

Re: [patch][gomp4] openacc loops

2014-06-13 Thread Thomas Schwinge
Hi Cesar! On Wed, 4 Jun 2014 20:42:16 -0700, Cesar Philippidis wrote: > The way that the loop clause > is handle in fortran is that all loops get lowered with the collapse > clause set. By default, for non-concurrent loops, collapse is set to 1. > And when collapse == 1, nothing special happens

Re: [patch][gomp4] openacc loops

2014-06-13 Thread Thomas Schwinge
Hi Ilmir! On Wed, 4 Jun 2014 17:53:38 +0400, Ilmir Usmanov wrote: > you should update tree-pretty-print.c (I forgot this): > @@ -675,13 +675,13 @@ dump_omp_clause (pretty_printer *buffer, tree > clause, int spc, int flags) > > case OMP_CLAUSE_WORKER: > pp_string (buffer, "worker("

Re: [patch][gomp4] openacc loops

2014-06-13 Thread Thomas Schwinge
Hi! On Wed, 4 Jun 2014 20:58:06 -0700, Cesar Philippidis wrote: > On 06/04/2014 06:53 AM, Ilmir Usmanov wrote: > >> @@ -1817,13 +1818,9 @@ scan_sharing_clauses (tree clauses, omp_context > >> *ctx) > >> case OMP_CLAUSE_PRIVATE: > >> case OMP_CLAUSE_FIRSTPRIVATE: > >> case OMP_C

Re: [patch][gomp4] openacc loops

2014-06-05 Thread Tobias Burnus
Janne Blomqvist wrote: Fortran does not allow aliasing of dummy arguments, That's not quite true: It permits aliasing variables (also without TARGET or POINTER attribute) – but if you modify one, you may no longer access the other, unless they do have the POINTER or TARGET attribute. (See be

Re: [patch][gomp4] openacc loops

2014-06-04 Thread Janne Blomqvist
On Wed, Jun 4, 2014 at 2:00 AM, Cesar Philippidis wrote: > One item on my to do list is adding support for subarrays in openacc in > fortran. So far I've got Ilmir's patch > to work with > some local arrays, but not with allocatable arrays

Re: [patch][gomp4] openacc loops

2014-06-04 Thread Cesar Philippidis
On 06/04/2014 06:53 AM, Ilmir Usmanov wrote: >> This patch, which is derived from Ilmir Usmanov's work posted here >> , implements >> the loop directive in openacc. The original patch is mostly intact, > Thank you! > > I looked through the

Re: [patch][gomp4] openacc loops

2014-06-04 Thread Cesar Philippidis
On 06/04/2014 12:49 PM, Thomas Schwinge wrote: (Note that I split up the original patches into two components. This is the omp-low.c component.) > On Tue, 3 Jun 2014 16:00:30 -0700, Cesar Philippidis > wrote: >> in order to make >> the patch yield more interesting results, I've also enabled the

Re: [patch][gomp4] openacc loops

2014-06-04 Thread Thomas Schwinge
Hi Cesar! On Tue, 3 Jun 2014 16:00:30 -0700, Cesar Philippidis wrote: > in order to make > the patch yield more interesting results, I've also enabled the private > clause. Is this patch ok for the gomp-4_0-branch? > gcc/ > * c/c-parser.c (c_parser_oacc_all_clauses): Update handling

Re: [patch][gomp4] openacc loops

2014-06-04 Thread Ilmir Usmanov
Hi Cesar! This patch, which is derived from Ilmir Usmanov's work posted here , implements the loop directive in openacc. The original patch is mostly intact, Thank you! I looked through the patch and found that you also added middle-end

[patch][gomp4] openacc loops

2014-06-03 Thread Cesar Philippidis
This patch, which is derived from Ilmir Usmanov's work posted here , implements the loop directive in openacc. The original patch is mostly intact, however, I did disable support for do concurrent loops since openacc 2.0a supports fortran up