[ping] Re: [patch,gomp4] error on invalid acc loop clauses

2015-06-02 Thread Cesar Philippidis
Any thoughts? Maybe I should just apply this patch to gomp-4_0-branch since it doesn't introduce any regressions. On 05/20/2015 04:26 PM, Cesar Philippidis wrote: > On 05/20/2015 07:32 AM, Jakub Jelinek wrote: > >> For OpenMP/OpenACC, there is still lots of diagnostics emitted during >> gimplific

Re: [patch,gomp4] error on invalid acc loop clauses

2015-05-20 Thread Cesar Philippidis
On 05/20/2015 07:32 AM, Jakub Jelinek wrote: > For OpenMP/OpenACC, there is still lots of diagnostics emitted during > gimplification and at the start of the omp lowering phases, so for > diagnostics purposes you can consider them as part of a common layer for all > the 3 FEs. Thanks, that makes

Re: [patch,gomp4] error on invalid acc loop clauses

2015-05-20 Thread Jakub Jelinek
On Wed, May 20, 2015 at 07:17:35AM -0700, Cesar Philippidis wrote: > > ..., and this: why not do such nesting checking in > > gcc/omp-low.c:check_omp_nesting_restrictions? Currently (changed by > > Bernd in internal r442824, 2014-11-29) we're allowing all > > OpenACC-inside-OpenACC nesting -- shou

Re: [patch,gomp4] error on invalid acc loop clauses

2015-05-20 Thread Cesar Philippidis
On 05/20/2015 01:23 AM, Thomas Schwinge wrote: >> I included two new test cases in this patch. They are mostly identical >> but, unfortunately, the c and c++ front ends emit slightly different >> error messages. > > The preference is to keep these as single files (so that C and C++ can > easily b

Re: [patch,gomp4] error on invalid acc loop clauses

2015-05-20 Thread Jakub Jelinek
On Wed, May 20, 2015 at 11:32:20AM +0200, Thomas Schwinge wrote: > Hi! > > On Wed, 20 May 2015 10:43:27 +0200, Jakub Jelinek wrote: > > On Wed, May 20, 2015 at 10:23:21AM +0200, Thomas Schwinge wrote: > > > I see that some checking is also being done gcc/omp-low.c:scan_omp_for: > > > »gang, worke

Re: [patch,gomp4] error on invalid acc loop clauses

2015-05-20 Thread Thomas Schwinge
Hi! On Wed, 20 May 2015 10:43:27 +0200, Jakub Jelinek wrote: > On Wed, May 20, 2015 at 10:23:21AM +0200, Thomas Schwinge wrote: > > I see that some checking is also being done gcc/omp-low.c:scan_omp_for: > > »gang, worker and vector may occur only once in a loop nest«, and »gang, > > worker and v

Re: [patch,gomp4] error on invalid acc loop clauses

2015-05-20 Thread Jakub Jelinek
On Wed, May 20, 2015 at 10:23:21AM +0200, Thomas Schwinge wrote: > > + if (gwv && auto_clause) > > +c_parser_error (parser, "incompatible use of clause %"); > > + else if (gwv && seq_clause) > > +c_parser_error (parser, "incompatible use of clause %"); > > + else if (auto_clause && seq_c

Re: [patch,gomp4] error on invalid acc loop clauses

2015-05-20 Thread Thomas Schwinge
Hi! On Fri, 15 May 2015 11:10:21 -0700, Cesar Philippidis wrote: > This patch teaches the c and c++ front ends to error on invalid and > conflicting acc loop clauses. E.g., an acc loop cannot have 'gang seq' > and the worker and vector clauses inside parallel regions cannot have > optional kerne

[patch,gomp4] error on invalid acc loop clauses

2015-05-15 Thread Cesar Philippidis
This patch teaches the c and c++ front ends to error on invalid and conflicting acc loop clauses. E.g., an acc loop cannot have 'gang seq' and the worker and vector clauses inside parallel regions cannot have optional kernel-specific arguments. The c and c++ front end also error when it detects a