Re: [patch, mips] Follow up to pr54061 patch, fix another abort.

2012-12-12 Thread Richard Sandiford
Steve Ellcey writes: > OK, you have convinced me. Here is what I am testing, OK to checkin > once I have run it through the testsuite? Yeah, looks good, thanks. Richard

Re: [patch, mips] Follow up to pr54061 patch, fix another abort.

2012-12-12 Thread Steve Ellcey
On Wed, 2012-12-12 at 08:21 +, Richard Sandiford wrote: > I'm pretty sure we'll need more eventually though. A quick inspection > shows that we don't set mips_dbx_regno for DSP_ACC_REGS or ST_REGS. > DSP_ACC_REGS in paticular seems likely to hit, although you need to > test with an -mdsp opti

Re: [patch, mips] Follow up to pr54061 patch, fix another abort.

2012-12-12 Thread Richard Sandiford
Steve Ellcey writes: > On Tue, 2012-12-11 at 21:52 +, Richard Sandiford wrote: > >> > + mips_dbx_regno[CPRESTORE_SLOT_REGNUM] = IGNORED_DWARF_REGNUM; > > >> If even fake registers like these are going to be used, then I think >> we should initialise to IGNORED_DWARF_REGNUM rather than INVALID

Re: [patch, mips] Follow up to pr54061 patch, fix another abort.

2012-12-11 Thread Steve Ellcey
On Tue, 2012-12-11 at 21:52 +, Richard Sandiford wrote: > > + mips_dbx_regno[CPRESTORE_SLOT_REGNUM] = IGNORED_DWARF_REGNUM; > If even fake registers like these are going to be used, then I think > we should initialise to IGNORED_DWARF_REGNUM rather than INVALID_REGNUM in: > > for (i = 0;

Re: [patch, mips] Follow up to pr54061 patch, fix another abort.

2012-12-11 Thread Richard Sandiford
"Steve Ellcey " writes: > While building libgcc in mips16 mode I found another instance of > dbx_reg_number aborting that the patch to pr54061 did not fix. > This code: > > extern void __chk_fail (void) __attribute__ ((__noreturn__)); > __strncpy_chk (s1, s2, n, s1len) > { > char c; > char *s

[patch, mips] Follow up to pr54061 patch, fix another abort.

2012-12-11 Thread Steve Ellcey
While building libgcc in mips16 mode I found another instance of dbx_reg_number aborting that the patch to pr54061 did not fix. This code: extern void __chk_fail (void) __attribute__ ((__noreturn__)); __strncpy_chk (s1, s2, n, s1len) { char c; char *s = s1; if (__builtin_expect (s1len < n, 0