Re: [patch, fortran] Put workaround for broken C/Lapack wrappers behind flag

2019-05-19 Thread Steve Kargl
On Sun, May 19, 2019 at 10:26:54AM +0200, Thomas Koenig wrote: > Hi Steve, > > > Looks good to me. I wonder if we should add a reference > > to the option that can produce C prototypes for a Fortran > > procedure in the description of -fbroken-caller. > > Thanks, I added a reference to that opti

Re: [patch, fortran] Put workaround for broken C/Lapack wrappers behind flag

2019-05-19 Thread Thomas Koenig
Hi Steve, Looks good to me. I wonder if we should add a reference to the option that can produce C prototypes for a Fortran procedure in the description of -fbroken-caller. Thanks, I added a reference to that option (see attached patch). Committed as r271376. Regards Thomas Index: C

Re: [patch, fortran] Put workaround for broken C/Lapack wrappers behind flag

2019-05-18 Thread Steve Kargl
On Sat, May 18, 2019 at 08:37:06PM +0200, Thomas Koenig wrote: > > the attached patch puts the workaround introduced by Jakub behind > a flag. I debated with myself what the name should be. > -fbroken-c-interfaces-die-die-die came to mind, but that would > have penalized people who wanted to disa

[patch, fortran] Put workaround for broken C/Lapack wrappers behind flag

2019-05-18 Thread Thomas Koenig
Hello world, the attached patch puts the workaround introduced by Jakub behind a flag. I debated with myself what the name should be. -fbroken-c-interfaces-die-die-die came to mind, but that would have penalized people who wanted to disable the option :-) Therefore, I have settled on -fbroken-ca