Re: *ping* [patch, fortran] Fix PR 96018, wrong code caused by implicit_pure

2020-07-18 Thread Paul Richard Thomas via Gcc-patches
Hi Thomas, I am fine with this being in frontend-passes.c - it was just a question :-) resolve.c has become too large anyway. The testcase looks familiar! Don't forget to commit and push the additional source too. OK for 10-- and all the affected branches. Cheers Paul On Sat, 18 Jul 2020 at

Re: *ping* [patch, fortran] Fix PR 96018, wrong code caused by implicit_pure

2020-07-18 Thread Thomas Koenig via Gcc-patches
Hi Paul, The patch looks fine to me but I have two questions: (i) Why is this not done in resolve.c? Of course it doesn't matter where the function resides :-) I put it into frontend-passes.c because it makes heavy use of gfc_code_walker, and out of habit. If you prefer, I can of course move

Re: *ping* [patch, fortran] Fix PR 96018, wrong code caused by implicit_pure

2020-07-18 Thread Paul Richard Thomas via Gcc-patches
Hi Thomas, The patch looks fine to me but I have two questions: (i) Why is this not done in resolve.c? (ii) Is Martin's reduced reproducer not the basis for a testcase? Regards Paul On Sat, 18 Jul 2020 at 11:58, Thomas Koenig via Fortran wrote: > Ping? > > > the attached patch fixes a 9/10/

*ping* [patch, fortran] Fix PR 96018, wrong code caused by implicit_pure

2020-07-18 Thread Thomas Koenig via Gcc-patches
Ping? the attached patch fixes a 9/10/11 regression where we left over an implicit_pure attribute when a non-implicit_pure procedure was called. The fix is explained in the ChangeLog.

[patch, fortran] Fix PR 96018, wrong code caused by implicit_pure

2020-07-10 Thread Thomas Koenig via Gcc-patches
Hello world, the attached patch fixes a 9/10/11 regression where we left over an implicit_pure attribute when a non-implicit_pure procedure was called. The fix is explained in the ChangeLog. If there is a quick review, please also indicate if you think it is still suitable for gcc 10.2. If the