Re: [patch, fortran] Fix PR 65428, ICE on nested empty array constructors

2020-01-09 Thread Thomas Koenig
Hi Tobias, I am not completely happy about the introduction of yet another two global variables, but I also do not see an easy way out. Hence: OK. Actually, I wasn't too happy myself, but, like you, I didn't find anything better. I was playing around with the following test case – you might c

Re: [patch, fortran] Fix PR 65428, ICE on nested empty array constructors

2020-01-08 Thread Tobias Burnus
Hello Thomas, sorry for the belated review. I am not completely happy about the introduction of yet another two global variables, but I also do not see an easy way out. Hence: OK. I was playing around with the following test case – you might consider to add them as well. (I would exclude the

*ping* [patch, fortran] Fix PR 65428, ICE on nested empty array constructors

2020-01-07 Thread Thomas Koenig
Am 02.01.20 um 23:35 schrieb Thomas Koenig: Hello world, the attached patch fixes an ICE where an array constructor containing an empty array constructor with a type didn't get the type from the inner constructor. The solution is to stash the type away in yet another variable and only use it if

[patch, fortran] Fix PR 65428, ICE on nested empty array constructors

2020-01-02 Thread Thomas Koenig
Hello world, the attached patch fixes an ICE where an array constructor containing an empty array constructor with a type didn't get the type from the inner constructor. The solution is to stash the type away in yet another variable and only use it if the constructor turns out to be empty, and t