Re: [patch, Fortran] PR61933 Inquire on Internal Units

2015-01-21 Thread Tobias Burnus
Am 22.01.2015 um 03:31 schrieb Jerry DeLisle: Also, I miss the test case. I assume that you still include it, don't you? Yes test case will be included. With those corrections OK? Yes. Thanks for the patch! Tobias

Re: [patch, Fortran] PR61933 Inquire on Internal Units

2015-01-21 Thread Jerry DeLisle
On 01/21/2015 03:33 PM, Tobias Burnus wrote: Hi Jerry et al., Jerry DeLisle wrote: I have added the following to libgfortran.h and used them (see patch) /* Special unit numbers used to convey certain conditions. Numbers -3 thru -9 available. NEWUNIT values start at -10. */ #define GFC_INT

Re: [patch, Fortran] PR61933 Inquire on Internal Units

2015-01-21 Thread Tobias Burnus
Hi Jerry et al., Jerry DeLisle wrote: I have added the following to libgfortran.h and used them (see patch) /* Special unit numbers used to convey certain conditions. Numbers -3 thru -9 available. NEWUNIT values start at -10. */ #define GFC_INTERNAL_UNIT -1 #define GFC_INVALID_UNIT -2

Re: [patch, Fortran] PR61933 Inquire on Internal Units

2015-01-20 Thread Jerry DeLisle
On 01/19/2015 11:28 PM, Tobias Burnus wrote: Hi Jerry, hi all, sorry for the slow patch review. I also still want to review your other inquire patch. Jerry DeLisle wrote: The fundamental problem: if the variable containing the unit number in an INQUIRE statement is of type KIND greater than 4

Re: [patch, Fortran] PR61933 Inquire on Internal Units

2015-01-19 Thread Tobias Burnus
Hi Jerry, hi all, sorry for the slow patch review. I also still want to review your other inquire patch. Jerry DeLisle wrote: The fundamental problem: if the variable containing the unit number in an INQUIRE statement is of type KIND greater than 4 and the value is outside the range of a KIN

Re: [patch, Fortran] PR61933 Inquire on Internal Units

2015-01-19 Thread Jerry DeLisle
ping This PR has been marked as a regression, so I suppose we ought to get it fixed. On 01/18/2015 09:10 PM, Jerry DeLisle wrote: I reopened this PR to do some cleanup and to address a use case presented by Joost in comment #7 of the subject PR. The fundamental problem: if the variable contain

[patch, Fortran] PR61933 Inquire on Internal Units

2015-01-18 Thread Jerry DeLisle
I reopened this PR to do some cleanup and to address a use case presented by Joost in comment #7 of the subject PR. The fundamental problem: if the variable containing the unit number in an INQUIRE statement is of type KIND greater than 4 and the value is outside the range of a KIND=4 we canno