Re: [omp4/cilkplus] jumps in/out-of #pragma simd for

2013-06-26 Thread Aldy Hernandez
On 06/26/13 10:33, Jakub Jelinek wrote: On Wed, Jun 26, 2013 at 09:44:03AM -0500, Aldy Hernandez wrote: This is a followup for the C++ changes (your pt.c suggested changes, etc). Only a few minor changes are needed, since c_finish_cilk_simd_loop() is shared between C/C++ and it creates the appr

Re: [omp4/cilkplus] jumps in/out-of #pragma simd for

2013-06-26 Thread Jakub Jelinek
On Wed, Jun 26, 2013 at 09:44:03AM -0500, Aldy Hernandez wrote: > This is a followup for the C++ changes (your pt.c suggested changes, etc). > > Only a few minor changes are needed, since c_finish_cilk_simd_loop() > is shared between C/C++ and it creates the appropriate CILK_SIMD > tree node. > >

Re: [omp4/cilkplus] jumps in/out-of #pragma simd for

2013-06-26 Thread Aldy Hernandez
This is a followup for the C++ changes (your pt.c suggested changes, etc). Only a few minor changes are needed, since c_finish_cilk_simd_loop() is shared between C/C++ and it creates the appropriate CILK_SIMD tree node. Is this what you had in mind? commit db2127098137dea6c246041e0d763a57a174f

Re: [omp4/cilkplus] jumps in/out-of #pragma simd for

2013-06-21 Thread Aldy Hernandez
case NE_EXPR: - if (!flag_enable_cilk) + /* NE_EXPR is only allowed for Cilk Plus loops. */ + if (flag_enable_cilk Very weird name of a flag. Should have been flag_cilk or flag_cilkplus IMHO. I know. It was already there from Balaji's first iteration with a

Re: [omp4/cilkplus] jumps in/out-of #pragma simd for

2013-06-21 Thread Richard Henderson
> case NE_EXPR: > - if (!flag_enable_cilk) > + /* NE_EXPR is only allowed for Cilk Plus loops. */ > + if (flag_enable_cilk > + && gimple_omp_for_kind (for_stmt) == GF_OMP_FOR_KIND_CILKSIMD) > + break; > + else > gcc_unreachable (); > -

Re: [omp4/cilkplus] jumps in/out-of #pragma simd for

2013-06-21 Thread Jakub Jelinek
On Fri, Jun 21, 2013 at 07:16:56AM -0500, Aldy Hernandez wrote: > I have done as suggested, and cleaned things up along the way. > > I believe this is the last remaining TODO on my Cilk Plus pragma > simd list. Everything else is dependent on OMP4. > > Is this what you had in mind? Roughly, yes

[omp4/cilkplus] jumps in/out-of #pragma simd for

2013-06-21 Thread Aldy Hernandez
[list copied] On 06/20/13 11:20, Jakub Jelinek wrote: On Wed, Jun 19, 2013 at 05:08:38PM -0500, Aldy Hernandez wrote: On 06/19/13 16:43, Jakub Jelinek wrote: On Wed, Jun 19, 2013 at 04:39:52PM -0500, Aldy Hernandez wrote: Jumps are disallowed into or out of the body of the for loop associated