Re: [libstdc++/61227] Support regex like "[\w]"

2014-05-19 Thread Tim Shen
On Mon, May 19, 2014 at 11:49 AM, Jonathan Wakely wrote: > The patch is OK with the ChangeLog tweak and omitting the new file. Booted, tested and committed. Thanks! -- Regards, Tim Shen

Re: [libstdc++/61227] Support regex like "[\w]"

2014-05-19 Thread Tim Shen
On Mon, May 19, 2014 at 11:28 AM, Paolo Carlini wrote: > I suggest rewording this or avoiding it completely. Sorry, I just can't tolerate my former quick & dirty code. On Mon, May 19, 2014 at 2:49 PM, Jonathan Wakely wrote: > I'm going to check in my factoring patches soon, so there's no need t

Re: [libstdc++/61227] Support regex like "[\w]"

2014-05-19 Thread Jonathan Wakely
On 19/05/14 11:08 -0400, Tim Shen wrote: * testsuite/28_regex/algorithms/regex_match/ecma/char/quoted_char.cc: New testcase. This sounds like it's adding a new file, not extending it with new tests. @@ -435,6 +439,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION std::vector<_CharT>

Re: [libstdc++/61227] Support regex like "[\w]"

2014-05-19 Thread Paolo Carlini
Hi, On 05/19/2014 05:08 PM, Tim Shen wrote: + // TODO Refactor this piece of junk. I suggest rewording this or avoiding it completely. Paolo.

[libstdc++/61227] Support regex like "[\w]"

2014-05-19 Thread Tim Shen
Here's the patch. I did a simple test on 28_regex/*. A bootstrap may be needed, but I can't do it now. -- Regards, Tim Shen commit 2fd6be816c1d1797b3aad228b9fb2cfb7374483c Author: tim Date: Mon May 19 10:40:16 2014 -0400 2014-05-19 Tim Shen PR libstdc++/61227 * include